Re: [Mutt] #3142: [SMTP] Invalid EHLO for some smtp sessions

[Rocco Rutte <pdmef@xxxxxxx>]

Hi,

* Mutt wrote:

> A patch is attached, the problem was an uninitialized variable and a wrong
> check of the DOMAIN string.

It's not that easy I think. If Fqdn is "@" it means uname() didn't
report a hostname and getdnsdomainname() returned -1 and mutt is
compiled without a fixed domain name. I.e. it can't determine a fqdn in
which case I think it should assume "localhost" (without domain which
can happen now, too if no dns domain name is found and uname() reports
localhost).

I don't know what's so special about DOMAIN == "@", the changeset
doesn't explain it but I bet there's a reason for it:

        changeset:   473:666f379a3b42
        branch:      HEAD
        user:        Thomas Roessler <roessler@xxxxxxxxxxxxxxxxxx>
        date:        Mon Oct 19 08:42:41 1998 +0000
        files:       init.c
        description:
        handle domain == "@" properly.

The last chunk of the patch can be skipped, too, since safe_strdup()
basically does malloc() and the copy.

Rocco