Re: mutt: 11 new changesets

[Rocco Rutte <pdmef@xxxxxxx>]

Hi,

* Brendan Cully wrote:

> http://dev.mutt.org/hg/mutt/rev/7b46e23ae476
> changeset:   5607:7b46e23ae476
> branch:      HEAD
> user:        Erik Hovland <erik@xxxxxxxxxxx>
> date:        Tue Dec 16 12:53:19 2008 -0800
> summary:     Remove redundant int clamping

I think this change is actually wrong. The sign of a%b in C is
machine-dependent for negative values. Thus,

         h = (h * SOMEPRIME) % n;
         h = (h >= 0) ? h : h + n;

ensures that h is always positive. So at least the former line needs to
go in again or it must be sure that the final return value is in the
range 0..n-1.

Rocco