Re: [PATCH] SSL intermediate certificates

[Brendan Cully <brendan@xxxxxxxxxx>]

On Sunday, 19 October 2008 at 14:47, TAKAHASHI Tamotsu wrote:
> Version 3.
> 
> * Sat Oct 18 2008 TAKAHASHI Tamotsu <ttakah@xxxxxxxxxxxxxxxxx>
> > +static STACK_OF(X509) *SslSessionCerts = NULL;
> > +#define CACHE_TRUSTED(c) \
> > +   if (!SslSessionCerts) \
> > +     SslSessionCerts = sk_new_null(); \
> > +   sk_X509_push (SslSessionCerts, c); \
> 
> This must be
>       sk_X509_push (SslSessionCerts, X509_dup(c)); \
> because the cert will be freed
> when the connection is closed.

This looks ok to me. Would you mind sending it as a whole patch? Also,
what do you think about turning CACHE_TRUSTED into a static inline? We
have too many macros :)

Attachment: pgpNUYvwkV_GX.pgp
Description: PGP signature