Re: [PATCH] Parent match

[Kyle Wheeler <kyle-mutt-dev@xxxxxxxxxxxxxx>]

On Thursday, November 13 at 12:17 PM, quoth Jeremie Le Hen:
> Attached you will find a patch introducing a new match pattern: =().
> Thanks to this pattern you can match the parent message of messages
> matching the inner pattern.

I don't disagree with the idea, but I do disagree with the syntax. All 
the other patterns use ~, =, and % to differentiate between different 
ways of matching the same information. For example, ~c uses a regex to 
search the CC headers, =c performs a string-based match on the CC 
headers, and %c performs a group-based match on the CC headers. This 
is consistent across all of the various letters that can be used: %c, 
%C, %e, and %f are all group-based variants of the ~ versions of those 
same searches. I don't think it's wise to create a new pattern that 
appears to be the same sort of variation but does not behave in the 
same way. =() looks like it will be a string-based version of ~(), 
even if that doesn't necessarily make any sense. I think it would be 
smarter to change the brackets; make the pattern be ~{} or ~[] 
instead.

~Kyle
--
Morality, like art, means drawing a line someplace.
                                                        -- Oscar Wilde

Attachment: pgphmMn7IMKCf.pgp
Description: PGP signature