Re: Segmentation fault from mutt-1.5.17 with SMTP
- To: mutt-dev@xxxxxxxx
- Subject: Re: Segmentation fault from mutt-1.5.17 with SMTP
- From: Kyle Wheeler <kyle-mutt-dev@xxxxxxxxxxxxxx>
- Date: Mon, 10 Nov 2008 09:01:42 -0600
- Comment: DomainKeys? See http://domainkeys.sourceforge.net/
- Dkim-signature: v=1; a=rsa-sha1; c=relaxed; d=memoryhole.net; h=date :from:to:subject:message-id:references:mime-version:content-type :in-reply-to; s=default; bh=lrXJmgqMvZ+U4zLv4hIlTlMRaH0=; b=S6XI 8RUXdP2B76EKbKOAbA3SDGx3/rlgR+s9hj2uMQa9zoWWM3UfzP5kdaf8eLLnLF15 NNFC86Jj385U1nvxMl01z1PJwQEP/8QLyIG9zHNMTikvcPFA+x0f8PnkhPlrJZ// MiWHQRmFpLTs7prnY6sWKUcdN6qGlbZwvXF2P6Y=
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=memoryhole.net; b=iVQVfPhivbkTcgVfxNGsPWiMZFo71rYUKA8k5gSHHWhclsl1qEQC/5P6994m86uliBAjfwGQko+8+b1sb/xh1ZCOHhWGWowtvnTZJOmpAaL9GDsUnjD92h2097XtkRzemD12xYSG0Znk6L7ciW9NPTleOMme2I/NVXExC3HDppQ=; h=Received:Received:Date:From:To:Subject:Message-ID:Mail-Followup-To:References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To:OpenPGP:User-Agent;
- In-reply-to: <20081110144216.GB21840@xxxxxxxxxxxxxxxxxxxxxxxxxx>
- List-post: <mailto:mutt-dev@mutt.org>
- List-unsubscribe: send mail to majordomo@mutt.org, body only "unsubscribe mutt-dev"
- Mail-followup-to: mutt-dev@xxxxxxxx
- Openpgp: id=CA8E235E; url=http://www.memoryhole.net/~kyle/kyle-pgp.asc; preference=signencrypt
- References: <20081110081517.GA21645@xxxxxxxxxxxxxxxxxxxxxxx> <20081110144216.GB21840@xxxxxxxxxxxxxxxxxxxxxxxxxx>
- Sender: owner-mutt-dev@xxxxxxxx
- User-agent: Mutt/1.5.18 (2008-10-30)
On Monday, November 10 at 11:42 PM, quoth TAKAHASHI Tamotsu:
This has already been fixed:
1970-01-01 00:00 +0000 Brendan Cully <brendan@xxxxxxxxxx> (a2e8f6fab8d3)
* smtp.c: Test that envelope from or from is set before attempting
SMTP delivery. Closes #3079.
Oh wait, since over 38 years ago?
Oh, wait, nevermind. The fix is in there, I just didn't see it the first time.
But I just noticed, shouldn't smtp.c have this patch:
--- smtp.old 2008-11-10 08:58:39.000000000 -0600
+++ smtp.c 2008-11-10 08:59:20.000000000 -0600
@@ -242,8 +242,7 @@ mutt_smtp_send (const ADDRESS* from, con
FREE (&AuthMechs);
/* send the sender's address */
- ret = snprintf (buf, sizeof (buf), "MAIL FROM:<%s>",
- EnvFrom ? EnvFrom->mailbox : from->mailbox);
+ ret = snprintf (buf, sizeof (buf), "MAIL FROM:<%s>", envfrom);
if (eightbit && mutt_bit_isset (Capabilities, EIGHTBITMIME))
{
safe_strncat (buf, sizeof (buf), " BODY=8BITMIME", 15);
It goes to all the trouble of setting envfrom, but then never uses it.
~Kyle
--
University politics are vicious precisely because the stakes are so
small.
-- Henry Kissinger
Attachment:
pgptmr6jJlzAw.pgp
Description: PGP signature