<<< Date Index >>>     <<< Thread Index >>>

Re: Changeset 2050b44407bf and qdbm

On Monday, 29 September 2008 at 17:47, Kyle Wheeler wrote:
> After changeset 2050b44407bf, I’m unable to compile with qdbm. I see that 
> configure.in is testing for $use_qdbm, but never sets it. Equivalent logic 
> is used in the tokyocabinet stuff, but I don’t see how that could possibly 
> work *either*, since $use_tokyocabinet is never set.

Ah. It looks like this bug is tripped only if you explicitly set
--use-qdbm or --use-tokyocabinet. If you leave out the options and let
mutt select the first one it finds, everything's fine. I'll push a
modified version of your patch.

> A small patch is attached that corrects that and lets it build properly.
>
> ~Kyle

> diff -r 9e569296190b configure.ac
> +++ b/configure.ac    Mon Sep 29 17:47:29 2008 -0500
> @@ -851,7 +851,7 @@
>           db_found=yes],
>          [CPPFLAGS="$OLDCPPFLAGS"
>           LDFLAGS="$OLDLDFLAGS"]))
> -      if test -n "$with_tokyocabinet" && test "$use_tokyocabinet" != yes
> +      if test -n "$with_tokyocabinet" && test "$db_found" != yes
>        then
>          AC_MSG_ERROR([Tokyo Cabinet could not be used. Check config.log for 
> details.])
>        fi
> @@ -883,7 +883,7 @@
>          [CPPFLAGS="$OLDCPPFLAGS"
>           LDFLAGS="$OLDLDFLAGS"])
>        LIBS="$saved_LIBS"
> -      if test -n "$with_qdbm" && test "$use_qdbm" != yes
> +      if test -n "$with_qdbm" && test "$db_found" != yes
>        then
>          AC_MSG_ERROR([QDBM could not be used. Check config.log for details.])
>        fi