Re: [PATCH] add sendbox feature

[Aron Griffis <agriffis@xxxxxxxxx>]

FYI, Rocco's comments on IRC:

< pdmef> agriffis: For that patch I'd rather not add two new
         options but only $sendbox and make mutt use whatever is
         non-empty from the chain: $sendbox -> $smtp_url ->
         $sendmail
< pdmef> agriffis: Also, why not simply add a function
         mutt_sendbox_send(), add it to sendlib.c and in that new
         function wrap writing an Fcc
< pdmef> agriffis: Or not even fcc but higher level append to
         mailbox so $sendbox could be any mailbox mutt can write
         to (i.e. all but POP3)?

< agriffis> pdmef: regarding $use_sendbox, you might be right.
            I'll review that
< agriffis> regarding mutt_sendbox_send() I'm not sure what that
            gains, but I'll check
< agriffis> regarding the last, it already works that way.
< agriffis> I use $sendbox pointing to a maildir when I'm using
            offlineimap, for example.

< pdmef> Ah okay, since you fcc and can fcc can be any mailbox
         type. Still, the patch looks rather long to me and seems
         to make mutt_write_fcc more complex.

< agriffis> hm, really?  I think the changes to mutt_write_fcc()
            are very small, actually...

< pdmef> agriffis: I didn't look to closely enough, you do most
         of that already.
< pdmef> agriffis: What I meant was to move the code changing
         _mutt_bounce_message() into sendlib.c
< pdmef> agriffis: send_message() there should prepare the
         message as needed so you can simple open the folder and
         append the message in mutt_send_sendbox().

< agriffis> pdmef: I'll see how to rework it as you recommend and
            get back to you.  Thanks for the comments.
            Unfortunately I'll have to wait until later because
            of work.

< pdmef> agriffis: No, that was no requirement, I just had
         a quick look at the code.
< pdmef> I just thought it might be better to have 3 lookalike
         interfaces for sending mail that are special-cased in
         only one place for later design improvement.
< pdmef> Right now I think using the Fcc feature for sending mail
         (i.e. adding a param to mutt_write_fcc()) is kind of abuse.

< agriffis> you might be right.  It was just the fewest mods that
            way.  I'll post an update sometime in the next couple
            days.