Re: [PATCH 1 of 3] Clean up error handling in mutt_copy_header
On Thursday, 10 July 2008 at 09:41, Aron Griffis wrote:
> # HG changeset patch
> # User Aron Griffis <agriffis@xxxxxxxxx>
> # Date 1215697105 14400
> # Branch HEAD
> # Node ID f005e1a25900d3df40963adcee04e384ac33b29b
> # Parent 2a9e9c487badce3ab39797d52d01666f36b07e7f
> Clean up error handling in mutt_copy_header
>
> mutt_copy_header unnecessarily tests the result of each fputc/fputs (well,
> most
> of them anyway, it's not consistent). This obfuscates the code and hides
> bugs.
> Remove these extraneous checks since ferror/feof are checked at the bottom of
> the function, and get rid of all the early returns.
>
> Signed-off-by: Aron Griffis <agriffis@xxxxxxxxx>
Pushed, thanks.