Re: [PATCH] Fix for OpenSolaris libidn

[Ralf Wildenhues <wildenhues@xxxxxxxxxxxxxxx>]

Hello David,

* David Champion wrote on Wed, Apr 23, 2008 at 07:33:45PM CEST:
> --- a/configure.ac    Thu Apr 03 17:08:13 2008 +0200
> +++ b/configure.ac    Wed Apr 23 12:33:27 2008 -0500
> @@ -1082,6 +1082,9 @@
>        AC_MSG_ERROR([IDN requested but iconv is disabled or unavailable])
>      fi
>    else
> +    if test "`uname -sr`" = "SunOS 5.11" -a -d /usr/include/idn; then

Please don't use 'test -a'.  Also, what when SunOS 5.12 comes out?
Wouldn't a check such as
  AC_CHECK_HEADERS([idn/idn-int.h],
    [CPPFLAGS="$CPPFLAGS -I/usr/include/idn"])

be better?

> +      CPPFLAGS="$CPPFLAGS -I/usr/include/idn"
> +    fi
>      AC_CHECK_LIB(idn, stringprep_check_version)
>      AC_CHECK_FUNCS(idna_to_unicode_utf8_from_utf8 idna_to_unicode_8z8z)
>      AC_CHECK_FUNCS(idna_to_ascii_from_utf8 idna_to_ascii_8z)

Cheers,
Ralf