Re: PATCH: mutt_progress_init() should not be called when

[Brendan Cully <brendan@xxxxxxxxxx>]

On Saturday, 08 March 2008 at 16:39, N.J. Mann wrote:
> Good afternoon,
> 
> 
> I've been working on a patch which affects the way mail boxes are
> processed.  My original work was based Mutt v1.5.17 RELEASE, but I
> decided I really ought to be using the nightly snapshots.  When I
> switched to the latter I noticed an very annoying regression: whenever
> my changes opened a mail box I got progress information at the bottom of
> the screen (although the various counts were always zero).  This was
> definitely not what I wanted!  After working out what had changed I came
> up with the following patch which fixes my problem.
> 
> Basically, in the mail box code calls to mutt_progress_update() are only
> made if ctx->quiet is clear, whereas calls to mutt_progress_init() do
> not test ctx->quiet.  I believe this to be a bug.  My patch adds
> suitable tests before the calls to mutt_progress_init().

Thanks, I've applied this (along with a corresponding check in pop.c).
There must be a nicer way to get the ctx->quiet flag to the progress bar though.