<<< Date Index >>>     <<< Thread Index >>>

Re: [PATCH] fix indent_string handling with format=flowed



Hi,

* Johannes Stezenbach [07-10-10 20:49:38 +0200] wrote:

"Don't use $indent_string to quote replies to flowed messages" is the
regression.

OK, sorry if I put you on the wrong track with the "|" thing -- this was
just used during testing. What I really want to do (and what worked before
but broke with the last mutt release) is to feed Outlook users the same
crap that they send me (they want it that way), but there are also a
few AppleMail users in the mix (they're the ones sending f=f):

I see. Using '|' was not really related to your example only, it rather shows what happens with an $indent_string other than '>' used in between.

I think when the code which my patch changes is executed, the f=f
message has already been converted to a non-f=f message, so it doesn't
make sense to suppress $indent_string handling at this stage.

Not really. First, touching rfc3676.c means you do touch the part that handles f=f. Second, mutt doesn't convert f=f to non-f=f. It only renders the message for your current terminal, making sure it's still a valid f=f message. To test this for yourself, edit your message (the parent of this reply) and add '; format=flowed' to the Content-Type: the part I wrote will be properly rendered as f=f because your mutt didn't convert it to non-f=f.

Mutt currently tries to keep interoperability by assuming that non-f=f aware clients (including mutt itself with $text_flowed unset) treat f=f mails just like any other mail and leave the spaces alone. As a result, non-f=f users won't notice the difference at all while f=f users still benefit from all f=f mails in a thread.

I think it's a good idea to keep it that way. But making mutt really "convert" f=f to non-f=f by removing the spaces wouldn't be too difficult either.

About the regression on your side: In addition to setting $indent_string and $attribution, you could more or less easily have a custom $editor script that strips leading '>' quotes mutt added.

Rocco