Re: [PATCH] pager_honours_reverse_sort

["Ben Walton" <bdwalton@xxxxxxxxx>]

Re-submitted.

Thanks
-Ben

On 10/9/07, Kyle Wheeler <kyle-mutt-dev@xxxxxxxxxxxxxx> wrote:
> On Tuesday, October  9 at 03:21 PM, quoth Ben Walton:
> >+              /* FIXME: Make this based on an option later */
> >+              if (option (OPTPAGERHONOURSREVERSE) && Sort & SORT_REVERSE)
> >+                      rc = OP_MAIN_PREV_UNDELETED;
> >+              else
> >+                      rc = OP_MAIN_NEXT_UNDELETED;
>
> The comment here looks like cruft.
>
> ~Kyle
> --
> The price of freedom of religion, or of speech, or of the press, is
> that we must put up with a good deal of rubbish.
>                                                       -- Robert Jackson
>
>


-- 
---------------------------------------------------------------------------------------------------------------------------
Ben Walton <bdwalton@xxxxxxxxx>

When one person suffers from a delusion, it is called insanity. When
many people suffer from a delusion it is called Religion.
Robert M. Pirsig, Zen and the Art of Motorcycle Maintenance

---------------------------------------------------------------------------------------------------------------------------

#diff -r 709db707bcdf init.h
--- a/init.h    Fri Sep 28 11:06:43 2007 +0200
+++ b/init.h    Tue Oct 09 16:04:08 2007 -0400
@@ -1398,6 +1398,13 @@ struct option_t MuttVars[] = {
   ** when you are at the end of a message and invoke the \fInext-page\fP
   ** function.
   */
+       { "pager_honours_reverse_sort", DT_BOOL, R_NONE, 
OPTPAGERHONOURSREVERSE, 0 },
+       /*
+        ** .pp
+        ** When set, the internal pager will move to the previous message 
instead
+        ** of the next message when paging past the bottom/end of the current
+        ** message.
+        */
   { "pgp_autosign",    DT_SYN,  R_NONE, UL "crypt_autosign", 0 },
   { "crypt_autosign",  DT_BOOL, R_NONE, OPTCRYPTAUTOSIGN, 0 },
   /*
#diff -r 709db707bcdf mutt.h
--- a/mutt.h    Fri Sep 28 11:06:43 2007 +0200
+++ b/mutt.h    Tue Oct 09 14:38:43 2007 -0400
@@ -409,6 +409,7 @@ enum
   OPTMIMEFORWDECODE,
   OPTNARROWTREE,
   OPTPAGERSTOP,
+  OPTPAGERHONOURSREVERSE,
   OPTPIPEDECODE,
   OPTPIPESPLIT,
 #ifdef USE_POP
#diff -r 709db707bcdf pager.c
--- a/pager.c   Fri Sep 28 11:06:43 2007 +0200
+++ b/pager.c   Tue Oct 09 16:01:39 2007 -0400
@@ -1897,7 +1897,10 @@ mutt_pager (const char *banner, const ch
        else
        {
          /* end of the current message, so display the next message. */
-         rc = OP_MAIN_NEXT_UNDELETED;
+               if (option (OPTPAGERHONOURSREVERSE) && Sort & SORT_REVERSE)
+                       rc = OP_MAIN_PREV_UNDELETED;
+               else
+                       rc = OP_MAIN_NEXT_UNDELETED;
          ch = -1;
        }
        break;