Re: [Mutt] #2901: wrong parameter micalg with mutt 1.5.15 and gpgme

[Mutt <fleas@xxxxxxxx>]

#2901: wrong parameter micalg with mutt 1.5.15 and gpgme

Comment (by MrTux):

 Replying to [comment:4 Paul Walker]:
 > If I've understood it right, if sizeof(buf) < 4 that loop will
 dereference
 > off the end of the array before checking the boundary condition. Maybe
 > switch the checks around?

 Yes, would be better. Whoever applies the patch should change this.

 But, in this case, I do not consider it critical; to create the situation
 you refer to, the source code must be altered in an unlikely way.

 Having a buffer with less than 4 bytes will most probably yield other
 problems first. ;)

-- 
Ticket URL: <http://dev.mutt.org/trac/ticket/2901#comment:5>