<<< Date Index >>>     <<< Thread Index >>>

Re: Bug 2874 ("> " quoting with f-f)



Hi,

* Daniel Jacobowitz [07-04-10 09:51:46 -0400] wrote:

diff -r 79a874c9ebaf rfc3676.c
--- a/rfc3676.c Tue Apr 10 08:26:56 2007 -0400
+++ b/rfc3676.c Tue Apr 10 09:48:58 2007 -0400
@@ -129,7 +129,7 @@ static void print_flowed_line (const cha
    }

    print_indent (ql, s);
-    if (ql > 0 || s->prefix)
+    if (ql > 0 || (s->prefix && option (OPTTEXTFLOWED)))
      state_putc (' ', s);
    state_puts (oldpos, s);

The original code (before I was asked to remove the space stuffing to make the handler behave like the old one did) had:

  if (ql > 0 || (s->prefix && !(s->flags & M_REPLYING)))

because a reply would be the only case then s->prefix could be set.

The first patch I sent re-adding the spaces contained that line, and I "corrected" it to the line without the replying check.

Unfortunately I have absolutely no time to read the mails/discussion on that issue until early next week.

But as the code with the M_REPLYING check worked for ages, I think it's okay to add it. The only place where this can unexpected results may be with forwarding such a mail inline, but I haven't checked.

  bye, Rocco
--
:wq!