<<< Date Index >>>     <<< Thread Index >>>

Re: [PATCH] Missing include of hcache.h in imap/util.c



Applied.

On Tuesday, 03 April 2007 at 10:35, Fabian Groffen wrote:
> On Gentoo some warnings are treated as fatal errors on 64-bits
> platforms.  While compiling the snapshot of 20070403, I got the
> following error:
> 
>  * QA Notice: Package has poor programming practices which may compile
>  *            but will almost certainly crash on 64bit architectures.
>  * Function `mutt_hcache_open' implicitly converted to pointer at util.c:84
> 
> What causes this is:
> util.c:84: warning: implicit declaration of function ‘mutt_hcache_open’
> 
> I solved this by simply including hcache.h as in the attached patch.
> 

> +++ imap/util.c
> @@ -28,6 +28,10 @@
>  #include "imap_private.h"
>  #include "mutt_ssl.h"
>  
> +#ifdef USE_HCACHE
> +# include "hcache.h"
> +#endif
> +
>  #include <stdlib.h>
>  #include <ctype.h>
>