Re: [Mutt] #1431: misleading --disable-external-dotlock
#1431: misleading --disable-external-dotlock functionality/ documentation vs.
naming/ intuition
Changes (by brendan):
* milestone: => 1.6
Old description:
> {{{
> Package: mutt
> Version: mutt-1.5.3-1
> Severity: normal
>
> -- Please type your report below this line
>
> I configured mutt (same problem in 1.4 and 1.5.3) with the following
> command:
>
> ./configure --enable-pop --enable-imap --disable-external-dotlock --with-
> ssl
>
> but despite the --disable-external-dotlock configure checks /var/mail
> ($mutt_cv_mailpath), finds that it is writable by group mail, and then
> configures to install mutt_dotlock setgid mail. However, when using mutt
> via imap the permissions on $mutt_cv_mailpath are totally irrelevant,
> thus
> if --disable-external-dotlock is specified no setgid mail mutt_dotlock
> program should be installed no matter what the permissions on
> $mutt_cv_mailpath are. The following patch to the configure script
> implements such a behaviour.
>
> ===========================================================================
> --- mutt-1.5.3/configure.nosetgid Tue Dec 17 02:35:56 2002
> +++ mutt-1.5.3/configure Mon Dec 23 15:44:44 2002
> @@ -4570,6 +4570,12 @@
> #define MAILPATH "$mutt_cv_mailpath"
> EOF
>
> +# Check whether --enable-external_dotlock or --disable-external_dotlock
> was given.
> +if test "${enable_external_dotlock+set}" = set; then
> + enableval="$enable_external_dotlock"
> + mutt_cv_external_dotlock="$enableval"
> +fi
> +
>
> echo $ac_n "checking if $mutt_cv_mailpath is world writable""...
> $ac_c" 1>&6
> echo "configure:4576: checking if $mutt_cv_mailpath is world writable"
> >&5
> @@ -4618,6 +4624,7 @@
>
> else
>
> + if test $mutt_cv_external_dotlock = yes; then
> echo $ac_n "checking if $mutt_cv_mailpath is group
> writable""... $ac_c" 1>&6
> echo "configure:4623: checking if $mutt_cv_mailpath is group writable"
> >&5
> if eval "test \"`echo '$''{'mutt_cv_groupwrite'+set}'`\" = set"; then
> @@ -4668,13 +4675,8 @@
>
> mutt_cv_setgid=yes
> fi
> + fi
> fi
> -fi
> -
> -# Check whether --enable-external_dotlock or --disable-external_dotlock
> was given.
> -if test "${enable_external_dotlock+set}" = set; then
> - enableval="$enable_external_dotlock"
> - mutt_cv_external_dotlock="$enableval"
> fi
>
> >How-To-Repeat:
> >Fix:
> }}}
New description:
I configured mutt (same problem in 1.4 and 1.5.3) with the following
command:
`./configure --enable-pop --enable-imap --disable-external-dotlock --with-
ssl`
but despite the --disable-external-dotlock configure checks /var/mail
($mutt_cv_mailpath), finds that it is writable by group mail, and then
configures to install mutt_dotlock setgid mail. However, when using mutt
via imap the permissions on $mutt_cv_mailpath are totally irrelevant, thus
if --disable-external-dotlock is specified no setgid mail mutt_dotlock
program should be installed no matter what the permissions on
$mutt_cv_mailpath are. The following patch to the configure script
implements such a behaviour.
{{{
--- mutt-1.5.3/configure.nosetgid Tue Dec 17 02:35:56 2002
+++ mutt-1.5.3/configure Mon Dec 23 15:44:44 2002
@@ -4570,6 +4570,12 @@
#define MAILPATH "$mutt_cv_mailpath"
EOF
+# Check whether --enable-external_dotlock or --disable-external_dotlock
was given.
+if test "${enable_external_dotlock+set}" = set; then
+ enableval="$enable_external_dotlock"
+ mutt_cv_external_dotlock="$enableval"
+fi
+
echo $ac_n "checking if $mutt_cv_mailpath is world writable""...
$ac_c" 1>&6
echo "configure:4576: checking if $mutt_cv_mailpath is world writable"
>&5
@@ -4618,6 +4624,7 @@
else
+ if test $mutt_cv_external_dotlock = yes; then
echo $ac_n "checking if $mutt_cv_mailpath is group
writable""... $ac_c" 1>&6
echo "configure:4623: checking if $mutt_cv_mailpath is group writable"
>&5
if eval "test \"`echo '$''{'mutt_cv_groupwrite'+set}'`\" = set"; then
@@ -4668,13 +4675,8 @@
mutt_cv_setgid=yes
fi
+ fi
fi
-fi
-
-# Check whether --enable-external_dotlock or --disable-external_dotlock
was given.
-if test "${enable_external_dotlock+set}" = set; then
- enableval="$enable_external_dotlock"
- mutt_cv_external_dotlock="$enableval"
fi
}}}
--
Ticket URL: <http://dev.mutt.org/trac/ticket/1431#comment:24>