<<< Date Index >>>     <<< Thread Index >>>

Re: [PATCH] Make f=f handler behave like old f=f handler for



On Wednesday, March 21 at 01:51 PM, quoth Paul Walker:
Well, some mutt docs say that when adding new features, the old should be default. Adding spaces back by force is a one liner. I can do that if it's

I'm confused here. The $indent_string variable should control what the quoting string is. Why is the space having to be added back in the mutt code, rather than the variable?

I think, and I may be wrong, but I seem to recall that the problem is that f=f messages have to have a specific quoting string that is specified in the RFC, thus, to make sure that you're generating legal messages, it has to ignore $indent_string.

And, there is a problem with blindly inserting spaces. If I receive an f=f message with something quoted (say, like this message):

    > this is a quoted line that
    > continues on the next line
    this is not a quoted line

Then inserting spaces blindly (esp. just following the strict $indent_string) will result in this:

    > > this is a quoted line that
    > > continues on the next line
    > this is not a quoted line

By the definition of f=f format, that means that the >> in the first line (and the > in the second) have lost their meaning in the official sense. They now just mean exactly what they are, and thus, if the text is reflowed by a mailer, the text would HAVE to become this:

    > > this is a quoted line that > continues on the next line
    > this is not a quoted line

And, if the "on the next line" line accidentally ends in a space, it may be reflowed like this:

    > > this is a quoted line that > continues on the next line this
    > is not a quoted line

Whereas, if we preserve the meaning of the previous quotes, like so:

    >> this is a quoted line that
    >> continues on the next line
    > this is not a quoted line

Reflowing them will end up with a correct text layout:

    >> this is a quoted line that continues on the next line
    > this is not a quoted line

And even if *all* the above lines end in spaces, the "this is not a quoted line" will remain separate from the line above it.

~Kyle
--
Just because you do not take an interest in politics doesn't mean politics won't take an interest in you.
                                                  -- Pericles (430 BC)

Attachment: pgpEGpTl0LHV3.pgp
Description: PGP signature