Re: [PATCH] runtime configurable buffy size
On Tuesday, 20 March 2007 at 18:42, Miroslav Lichvar wrote:
> On Tue, Mar 20, 2007 at 09:50:34AM -0700, Brendan Cully wrote:
> > > > this looks a little like it should be a conditional on
> > > > option(CHECKMBOXSIZE).
> > >
> > > I think it's ok either way. Without the conditional it's a bit
> > > closer to allowing runtime switching of the option and not losing
> > > new mail flags on the mailboxes.
> >
> > I doubt this matters. Some users need the size check and some don't,
> > but I would guess very few need to be able to switch between size and
> > atime on the fly. And I do somewhat prefer not calling code that will
> > generally not have any effect. Can you think of a reasonable case
> > where you'd want to switch this option interactively (as opposed to at
> > startup)?
>
> Hm, can't think of anything. The conditional is fine with me, do you want
> me to send another patch?
That'd be great.