<<< Date Index >>>     <<< Thread Index >>>

Re: [PATCH] Make mutt_FormatString multibyte aware



Hi,

* Rocco Rutte [07-03-19 11:53:47 +0000] wrote:
For the %> and %| expandos in format strings, mutt used 'ch = *src++' to
extract the pad character which works for single-byte locales only.
We now use a multibyte aware get_mbchar() to extract it.

...what I'm in particular not sure of his how mutt_FormatString() prevents buffer overflows by implementing length checking. It may well be that this patch introduces them since padding with a multibyte char may require a string being several times as large (bytes) as the terminal width.

I'm waiting for some other people to test it (and maybe provide some hints for cleaning it up) and will look into these issues to get it ready for inclusion.

  bye, Rocco
--
:wq!