<<< Date Index >>>     <<< Thread Index >>>

[PATCH] Re: Segfault with CVS mutt



On 2/10/07, David Shaw <dshaw@xxxxxxxxxxxxxxx> wrote:
On Sat, Feb 10, 2007 at 08:14:44PM -0800, Ken Brush wrote:

> There's the problem this line:
> 5< a0005 NO There is insufficient disk space to complete operation.
>
> There is a problem with your imap server. Most clients would continue
> on and just try to retrieve all the messages it can. But RFC 2046
> requires an OK from a Fetch operation.
>
> And the code in mutt does check and returns back the "Error opening
> mailbox" error otherwise. (which is honestly, a better way of doing
> it. We don't want silly things like deletes and what not to screw up
> all your mail, do we?)

No question that there was a problem on the IMAP server.  However that
problem caused mutt to dereference garbage and segfault.  That's not a
good response to a wonky IMAP server as no matter how broken the
server is, it should not be able to crash mutt.  The bug here is the
crash, not the inability to open the mailbox.

David

Ok, I've attached a patch that fixes this bug.

-Ken

Attachment: patch-1.5.13.kb.imap_segfault_on_corruption.1
Description: Binary data