mutt/2603: bogus CPPFLAGS Makefile.am

[jel@xxxxxxxxxxxxxxxxxxx]

>Number:         2603
>Notify-List:    
>Category:       mutt
>Synopsis:       bogus CPPFLAGS Makefile.am
>Confidential:   no
>Severity:       normal
>Priority:       medium
>Responsible:    mutt-dev
>State:          open
>Keywords:       
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Dec 10 05:31:58 +0100 2006
>Originator:     jel@xxxxxxxxxxxxxxxxxxx
>Release:        1.4.2.2
>Organization:
>Environment:
Solaris (all)
>Description:
Makefile.am: CPPFLAGS=@CPPFLAGS@ -I$(includedir)

One should NOT include blindly the destination include directory, since the 
includes required for compilation might not reside in that directory.

E.g. if on has installed ncurses on Solaris in /usr/local and thus has 
CPPFLAGS/CFLAGS set to -I/usr/local/include, compilation breaks, because the 
preprocessor uses the termcap includes from /usr/include (curses.h), which is 
different wrt. the ncuses curses.h ...
E.g.: /usr/include/curses.h has
#define vidattr         vid32attr
#define wattroff        w32attroff
#define wattron         w32attron
#define wattrset        w32attrset
#define acs_map         acs32map
#define box             box32

but ncurses doesn't provide any *32* functions ...
>How-To-Repeat:
>Fix:
gsed -i -e 's,-I$(includedir),,' Makefile.*
>Add-To-Audit-Trail:

>Unformatted: