<<< Date Index >>>     <<< Thread Index >>>

Re: [PATCH] display search progress with $search_inc



Hi,

* Brendan Cully [06-11-14 10:20:26 -0800] wrote:

I think it'd probably be good to try to unify the progress code
somehow, so that things using read_inc/write_inc/search_inc/net_inc go
through the same code path. And I think the way to save screen updates
might be to cache the last value (I think there's a field for that in
the progress bar struct) and skip printing if the value is unchanged.

Okay. I think I've looked at that idea once but got stuck with the way mbox does it for read_inc (via ftell() IIRC to get very exact progress).
I hope I'll have some more time this week to look into again.

Also, I think it's fine if read_inc controls search progress as
well. Searching can be seen as a form of reading.

Okay. Once done, it shouldn't be too complicated to re-add $search_inc if in case people don't mind...

  bye, Rocco
--
:wq!