mutt/2547: doc/Makefile.in hard-codes SHELL, breaking make on Solaris

[carson@xxxxxxxxxx]

>Number:         2547
>Notify-List:    
>Category:       mutt
>Synopsis:       doc/Makefile.in hard-codes SHELL, breaking make on Solaris
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    mutt-dev
>State:          open
>Keywords:       
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Nov 04 02:44:07 +0100 2006
>Originator:     carson@xxxxxxxxxx
>Release:        
>Organization:
>Environment:
Any system where /bin/sh is not bash, specifically Solaris 10 x86
>Description:
doc/Makefile.in contains "SHELL = /bin/sh" instead of "SHELL = @SHELL@". 
/bin/sh throws an error on:

( sed -e "s/@VERSION\@/`cat $(top_srcdir)/VERSION` (`cut -d\\" -f2 
$(top_srcdir)/reldate.h`)/" $(srcdir)/manual.xml.head ;\
          $(MAKEDOC_CPP) $(top_srcdir)/init.h | ../makedoc -s ) |      \
                cat - $(srcdir)/manual.xml.tail > manual.xml

bash is happy with it, but /bin/sh and /bin/ksh are not. It looks like the real 
problem may be cut -d\\", if I change it to cut -d\", all shells appear to work 
properly.
>How-To-Repeat:
Run make in doc on Solaris (or any other system where /bin/sh is not bash).
>Fix:
See attached patch for doc/makefile.in
>Add-To-Audit-Trail:

>Unformatted:
 ----gnatsweb-attachment----
 Content-Type: application/octet-stream; name="doc-makefile.patch"
 Content-Transfer-Encoding: base64
 Content-Disposition: attachment; filename="doc-makefile.patch"
 
 LS0tIE1ha2VmaWxlLmluLkRJU1QJMjAwNi0xMS0wMyAxNzo0NDowMC4yOTEzNjcwMDAgLTA4MDAK
 KysrIE1ha2VmaWxlLmluCTIwMDYtMTEtMDMgMTc6NDQ6MjAuMjgzMDMzMDAwIC0wODAwCkBAIC0x
 LDYgKzEsNiBAQAogIyAkSWQ6IE1ha2VmaWxlLmluLHYgMy4yNCAyMDA2LzA3LzA0IDE4OjU2OjA0
 IGJyZW5kYW4gRXhwICQKIAotU0hFTEwgPSAvYmluL3NoCitTSEVMTCA9IEBTSEVMTEAKIAogUEFD
 S0FHRSA9IEBQQUNLQUdFQAogVkVSU0lPTiA9IEBWRVJTSU9OQApAQCAtMTg0LDcgKzE4NCw3IEBA
 CiBzdGFtcC1kb2MteG1sOiAkKHRvcF9zcmNkaXIpL21ha2Vkb2MuYyAkKHRvcF9zcmNkaXIpL2lu
 aXQuaCBtYW51YWwueG1sLmhlYWQgbWFudWFsLnhtbC50YWlsIFwKICAgICAgICAgICAgICAgICQo
 dG9wX3NyY2RpcikvVkVSU0lPTiAkKHRvcF9zcmNkaXIpL3JlbGRhdGUuaAogCSQoTUFLRSkgLi4v
 bWFrZWRvYyQoRVhFRVhUKQotCSggc2VkIC1lICJzL0BWRVJTSU9OXEAvYGNhdCAkKHRvcF9zcmNk
 aXIpL1ZFUlNJT05gIChgY3V0IC1kXFwiIC1mMiAkKHRvcF9zcmNkaXIpL3JlbGRhdGUuaGApLyIg
 JChzcmNkaXIpL21hbnVhbC54bWwuaGVhZCA7XAorCSggc2VkIC1lICJzL0BWRVJTSU9OXEAvYGNh
 dCAkKHRvcF9zcmNkaXIpL1ZFUlNJT05gIChgY3V0IC1kXCIgLWYyICQodG9wX3NyY2RpcikvcmVs
 ZGF0ZS5oYCkvIiAkKHNyY2RpcikvbWFudWFsLnhtbC5oZWFkIDtcCiAJICAkKE1BS0VET0NfQ1BQ
 KSAkKHRvcF9zcmNkaXIpL2luaXQuaCB8IC4uL21ha2Vkb2MgLXMgKSB8ICAgICAgXAogCQljYXQg
 LSAkKHNyY2RpcikvbWFudWFsLnhtbC50YWlsID4gbWFudWFsLnhtbAogCXRvdWNoIHN0YW1wLWRv
 Yy14bWwK