<<< Date Index >>>     <<< Thread Index >>>

Re: mutt/2472: header caching for MH-style folders does not work



The following reply was made to PR mutt/2472; it has been noted by GNATS.

From: Rocco Rutte <pdmef@xxxxxxx>
To: bug-any@xxxxxxxxxxxxx
Cc: 
Subject: Re: mutt/2472: header caching for MH-style folders does not work
Date: Tue, 5 Sep 2006 08:36:49 +0000

 Hi,
 
 * tim.hunter@xxxxxxxxxx [06-09-04 19:42:05 +0200] wrote:
 
 >the header cache does not get populated when a MH folder is opened.
 [...]
 >patch attached
 
 Hmm, I don't really like the patch. If the problem is in hcache.c in 
 function mutt_hcache_fetch_raw(), why not ask here for why the 
 'filename++' line is in there? If a leading slash is a problem in some 
 cases, hcache.c should be fixed in the first place.
 
 If a leading / needs to be skipped, the patch maybe could be as simple 
 as:
 
    if (*filename=='/')
      filename++;
 
 instead of:
 
    filename++;
 
 and add a comment line on why the / needs to be skipped.
 
    bye, Rocco
 -- 
 :wq!