Re: mutt/2333: wish: display multiple ?variables at once
The following reply was made to PR mutt/2333; it has been noted by GNATS.
From: Alain Bench <veronatif@xxxxxxx>
To: bug-any@xxxxxxxxxxxxx
Cc:
Subject: Re: mutt/2333: wish: display multiple ?variables at once
Date: Thu, 13 Jul 2006 21:02:42 +0200 (CEST)
On Sunday, July 9, 2006 at 8:25:01 +0200, Tamotsu Takahashi wrote:
[tamo/multiquery2.diff]
> unnecessary line: "*err->data = '\0';" at the beginning of parse_set.
> [...] replace "size_t errlen = 0;" with "size_t errlen = mutt_strlen
> (err->data);"
Done both, and all seems well so far. I continue stress testing.
Problem with long line truncation: Whatever screen size, the string
is truncated at 127 bytes, and displayed as an error, in red with a
beep. Example:
| :color error brightred default
| :set beep
| :set
from=789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.
| :set ?from
|
from="789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.123456789.1234567
Perhaps would be preferable:
-1) More than 127 bytes. Enough to avoid truncation on the widest
terminals.
-2) Silent no error truncation, as without multiquery2.diff. Lack of
closing double quotes is enough visual hint. And COLS-2 truncation of
strings on 80 columns terminal is already silent. I mean user cares
about truncated display; not if it comes from columns or bytes.
Furthermore this truncation error prevents later commands to be
executed, and eventual later real errors to be reported:
| :set ?from from=123 typo=456
This shouts the same "from=...long..." error, and does not change
$from. It should better change $from and shout error:
| typo: unknown variable
Bye! Alain.
--
How to Report Bugs Effectively
<URL:http://www.chiark.greenend.org.uk/~sgtatham/bugs.html>