<<< Date Index >>>     <<< Thread Index >>>

[PATCH] Generalize mailbox ACL concept



Hi,

right now the message flags for POP are done a little ugly as the hcache problem isn't solved. However, in the future I'd like to have full flag support for POP based on hcache and none if built without it.

To have clean code, I'd like to have this choice in pop.c but that means that the UI (index+pager) cannot have their POP-specific flag checks any longer.

My solution so far is to generalize the ACL concept so that all folders in theory can some. It's up to the mailbox driver to set/unset them.

I started with the IMAP ACL set as it's obviously the superset and hard-coded the POP "ACLs" we support right now.

Also, the patch beautifies the error messages for prohibited ACL and removes special-casing for IMAP, which is a good thing by means of separation of UI and logic.

The patch only moves definitions around and adjusts consumers so there shouldn't be a functional change at all. For POP I can verify this, but I have no IMAP mailbox with ACLs... so feedback is welcome.

Find the patch at:

  
<http://user.cs.tu-berlin.de/~pdmef/mutt/patches/patch-1.5.11-cvs.pdmef.mxacl.1.diff>

and a more detailed explanation of reasoning than this mail:

  
<http://user.cs.tu-berlin.de/~pdmef/mutt/patches/patch-1.5.11-cvs.pdmef.mxacl.1.txt>

  bye, Rocco
--
:wq!