<<< Date Index >>>     <<< Thread Index >>>

solved! (was: Re: mutt/2205: problem with long lines in mailcap files)



The following reply was made to PR mutt/2205; it has been noted by GNATS.

From: Gregor Zattler <telegraph@xxxxxxx>
To: bug-any@xxxxxxxxxxxxx
Cc: 
Subject: solved! (was: Re: mutt/2205: problem with long lines in mailcap files)
Date: Fri, 28 Apr 2006 16:01:47 +0200

 Hi Takahasi,
 
 * TAKAHASHI Tamotsu <ttakah@xxxxxxxxxxxxxxxxx> [27. Apr. 2006]:
 > The following reply was made to PR mutt/2205; it has been noted by GNATS.
 > 
 > From: TAKAHASHI Tamotsu <ttakah@xxxxxxxxxxxxxxxxx>
 > To: bug-any@xxxxxxxxxxxxx
 > Cc: 
 > Subject: Re: mutt/2205: problem with long lines in mailcap files
 > Date: Fri, 28 Apr 2006 00:59:12 +0900
 > 
 >  Hi Gregor,
 >  
 >  * Thu Apr 27 2006 Gregor Zattler <telegraph@xxxxxxx>
 >  >  o.k. first I changed the ..._STRING sizes in lib.h by a factor of
 >  >  10: 51200, 10240, 2560, 1280.  This did the trick.
 >  >  
 >  >  I then changed them back to the original values and changed
 >  >  LONG_STRING to HUGE_STRING in rfc1524.c.  This did not solve the
 >  >  problem.  I then exchanged the occourences of *STRING one after
 >  >  the other with the next larger type.  This did not help...
 >  
 >  So I was wrong.
 >  The problem is in mutt_view_attachment (in attach.c).
 >  
 >  --- a/attach.c      Sat Mar 11 14:03:43 2006 +0900
 >  +++ b/attach.c      Fri Apr 28 00:49:46 2006 +0900
 >  @@ -416,7 +416,7 @@ int mutt_view_attachment (FILE *fp, BODY
 >     int use_pipe = 0;
 >     int use_pager = 1;
 >     char type[STRING];
 >  -  char command[STRING];
 >  +  char command[HUGE_STRING];
 >     char descrip[STRING];
 >     char *fname;
 >     rfc1524_entry *entry = NULL;
 
 This really solved the problem.  Thank you very much Takahashi.
 Since this bug was triggered by a attachment whichs name is
 060315BMASVorgeseheneAenderungenImSGBIIOptimierungsgesetz.pdf I
 think this patch (or maybe LONG_STRING instead of HUGE_STRING)
 should get commited.
 
 Thomas?
 
 Ciao, Gregor
 -- 
  -... --- .-. . -.. ..--.. ...-.-