Any reason to mark read messages as old?

[Brendan Cully <brendan@xxxxxxxxxx>]

While fixing the Old message flag for IMAP (one of several changes
I'll commit tomorrow), I noticed that mutt marks all messages as old
if mark_old is set, not just unread ones. Is there a reason for this?
If not I'd like to turn it off to avoid spamming my mailboxes with the
flag.

At first I was annoyed because the IMAP sync code insisted on tagging
every message individually, but I've fixed that this weekend - sync
should be much faster tomorrow. Still, I can't see the harm of
applying the attached patch. But it seems so obvious I figure I must
be missing something. What is it?

# HG changeset patch
# User Brendan Cully <brendan@xxxxxxxxxx>
# Node ID c40319a9d576b281d4f9240d5224b50fc6c825dc
# Parent  ff6c97ced86f07d47cb9b6a82de54fa26bb932a9
Only mark unread messages old

diff -r ff6c97ced86f -r c40319a9d576 mx.c
--- a/mx.c      Sun Dec 18 16:19:03 2005
+++ b/mx.c      Sun Dec 18 16:19:59 2005
@@ -904,7 +904,7 @@
   {
     for (i = 0; i < ctx->msgcount; i++)
     {
-      if (!ctx->hdrs[i]->deleted && !ctx->hdrs[i]->old)
+      if (!ctx->hdrs[i]->deleted && !ctx->hdrs[i]->old && !ctx->hdrs[i]->read)
        mutt_set_flag (ctx, ctx->hdrs[i], M_OLD, 1);
     }
   }

Attachment: pgpjgtQUW1d41.pgp
Description: PGP signature