<<< Date Index >>>     <<< Thread Index >>>

Re: mutt/2142: <untag-pattern> with empty argument does nothing



The following reply was made to PR mutt/2142; it has been noted by GNATS.

From: Vincent Lefevre <vincent@xxxxxxxxxx>
To: bug-any@xxxxxxxxxxxxx
Cc: 
Subject: Re: mutt/2142: <untag-pattern> with empty argument does nothing
Date: Thu, 24 Nov 2005 17:19:01 +0100

 On 2005-11-24 13:55:01 +0100, Thomas Roessler wrote:
 >  I can basically see good arguments for both sides:
 >  
 >  - Intuitively, when I delete a limit pattern, shouldn't I also
 >    remove its effect?
 >  
 >  - On the other hand, pretty much all prompts in mutt take an
 >    empty input to mean "abort".
 
 One can also assume that there always is a limit pattern (~A by default)
 and that "delete a limit pattern" does not make any sense.
 
 >  >  The previous limit pattern may be very complicated. So,
 >  >  it's not necessarily easy to get back to the previous
 >  >  limit.
 >  
 >  You forgot the history function. ;-)
 
 The history function won't necessarily be useful here since the
 history is shared with the search history (which is fine, BTW).
 I often do a limit first, then refine the search with "normal"
 searches.
 
 >  Whatever.  The principle of least surprise speaks strongly in
 >  favor of the old behavior.  And maybe a little message in the
 >  status line could help to take care of the original usability
 >  problem?
 
 Good idea.
 
 >  diff -u -r3.34 curs_main.c
 >  --- curs_main.c     4 Oct 2005 04:29:09 -0000       3.34
 >  +++ curs_main.c     24 Nov 2005 12:48:46 -0000
 >  @@ -868,6 +868,8 @@
 >          mutt_draw_tree (Context);
 >        menu->redraw = REDRAW_FULL;
 >      }
 >  +        if (Context->pattern)
 >  +     mutt_message _("To view all messages, limit to \"all\".");
 
 Or:
 
   To view all messages, limit to "all", "." or "~A".
 
 That way, the user would also learn that "<limit>." is the fastest
 way to view all messages.
 
 -- 
 Vincent Lefèvre <vincent@xxxxxxxxxx> - Web: <http://www.vinc17.org/>
 100% accessible validated (X)HTML - Blog: <http://www.vinc17.org/blog/>
 Work: CR INRIA - computer arithmetic / SPACES project at LORIA