<<< Date Index >>>     <<< Thread Index >>>

Re: mutt/2019: menu_context itches



The following reply was made to PR mutt/2019; it has been noted by GNATS.

From: Thomas Roessler <roessler@xxxxxxxxxxxxxxxxxx>
To: bug-any@xxxxxxxxxxxxx, ossi@xxxxxxx
Cc: Mutt Developers <mutt-dev@xxxxxxxx>
Subject: Re: mutt/2019: menu_context itches
Date: Thu, 17 Nov 2005 18:20:23 +0100

 On 2005-11-03 18:45:03 +0100, Oswald Buddenhagen wrote:
 
 >  now, 1) if the index has fewer lines than menu_context and the
 >  number of lines is odd/even (pick one :), menu_context seems to
 >  have no effect at all (the cursor should be just kept in the
 >  middle, like it is in the other case). 2) when the index is long
 >  enough, the cursor can still have an initial position outside
 >  menu_context; this also happens after resizing the terminal.
 >  this leads either to scrolling in the wrong direction or to a
 >  jump recenter, depending on the terminal size (i think).
 
 Mhhh...  Basically, if menu_context grows too large, we want
 menu_scroll behavior regardless of whether or not that option is
 set.
 
 I seem to be unable to reproduce the problems that we've seen with
 the attached patch against current CVS, but I might still overlook
 some corner case.
 
 --=20
 Thomas Roessler =B7 Personal soap box at <http://log.does-not-exist.org/>.
 
 
 
 diff -u -r3.23 menu.c
 --- menu.c     1 Nov 2005 08:42:00 -0000       3.23
 +++ menu.c     17 Nov 2005 17:19:29 -0000
 @@ -379,36 +379,27 @@
 =20
    if (!option (OPTMENUMOVEOFF) && menu->max <=3D menu->pagelen) /* less en=
 tries than lines */
    {
 -    if (menu->top !=3D 0) {
 +    if (menu->top !=3D 0)=20
 +    {
        menu->top =3D 0;
        set_option (OPTNEEDREDRAW);
      }
    }
    else=20
    {
 -    /*=20
 -     * If c =3D menu->pagelen / 2 and menu->pagelen is even, then (obvious=
 ly):
 -     *=20
 -     *   menu->top + menu->pagelen - c =3D=3D menu->top + c
 -     *
 -     * In that case, having an "else if" below leads to what has become kn=
 own as the
 -     * indicator break dance effect.  Instead of special-casing, we just f=
 orget the=20
 -     * "else".
 -     */
 -   =20
 -    if (menu->current < menu->top + c) /* indicator above top threshold */
 +    if (option (OPTMENUSCROLL) || (menu->pagelen <=3D 0) || c <=3D MenuCon=
 text)
      {
 -      if (option (OPTMENUSCROLL) || (menu->pagelen <=3D 0))
 +      if (menu->current < menu->top + c)
        menu->top =3D menu->current - c;
 -      else
 -      menu->top -=3D (menu->pagelen - c) * ((menu->top + menu->pagelen - 1 - 
me=
 nu->current) / (menu->pagelen - c)) - c;
 +      if (menu->current >=3D menu->top + menu->pagelen - c)
 +      menu->top =3D menu->current - menu->pagelen + c + 1;
      }
 -    if (menu->current >=3D menu->top + menu->pagelen - c) /* indicator bel=
 ow bottom threshold */
 +    else
      {
 -      if (option (OPTMENUSCROLL) || (menu->pagelen <=3D 0))
 -      menu->top =3D menu->current - menu->pagelen + c + 1;
 -      else
 -      menu->top +=3D (menu->pagelen - c) * ((menu->current - menu->top) / 
(menu=
 ->pagelen - c)) - c;
 +      if (menu->current < menu->top + c)
 +      menu->top -=3D (menu->pagelen - c) * ((menu->top + menu->pagelen - 1 - 
me=
 nu->current) / (menu->pagelen - c)) - c;
 +      else if (menu->current >=3D menu->top + menu->pagelen - c)
 +      menu->top +=3D (menu->pagelen - c) * ((menu->current - menu->top) / 
(menu=
 ->pagelen - c)) - c;=09
      }
    }
 =20