Re: mutt/2023: national symbols in push argument ignored

[Alain Bench <veronatif@xxxxxxx>]

The following reply was made to PR mutt/2023; it has been noted by GNATS.

From: Alain Bench <veronatif@xxxxxxx>
To: bug-any@xxxxxxxxxxxxx
Cc: Max Kirillov <max630@xxxxxxx>,
 =?iso-8859-1?Q?Micka=EBl?= Leducq <micled@xxxxxxx>
Subject: Re: mutt/2023: national symbols in push argument ignored
Date: Sun, 14 Aug 2005 19:34:04 +0200 (CEST)

 --Boundary_(ID_jMXNb1tsw3zyAbt71BxhrQ)
 Content-type: text/plain; charset=iso-8859-1
 Content-transfer-encoding: QUOTED-PRINTABLE
 
 Hello Tamo, Max, and Micka=EBl.
 
  On Wednesday, August 3, 2005 at 1:25:02 PM +0200, Tamotsu Takahashi =
 wrote:
 
 > I guess, perhaps parse_keycode() will allow you to push
 > "<tag-pattern>a<304>a". But I'm not sure. Untested.
 
     It doesn't seem to work, nor to be the way to go. It seems better=
  to
 just permit to push any chars even 8 bits, like is permitted to type
 directly. The following cast seems to work in Max case, as well as in
 UTF-8 locale. It also fixes Micka=EBl case of eaten non-Ascii chars i=
 n
 macros (bugs 1495/1496).
 
 
 Bye!=09Alain.
 --=20
 Everything about locales on Sven Mascheck's excellent site at new
 location <URL:http://www.in-ulm.de/~mascheck/locale/>. The little tes=
 ter
 utility is at <URL:http://www.in-ulm.de/~mascheck/locale/checklocale.=
 c>.
 
 
 --Boundary_(ID_jMXNb1tsw3zyAbt71BxhrQ)
 Content-type: TEXT/PLAIN; NAME=patch-1.5.10.ab.bug2023_push_8bits.2
 Content-transfer-encoding: QUOTED-PRINTABLE
 Content-disposition: attachment; filename=patch-1.5.10.ab.bug2023_push_8bits.2
 
 push 8 bits chars: fix bug 2023
 in macro: fix bugs 1495/1496
 AB.
 
 diff -prud mutt-1.5.10/keymap.c mutt-1.5.10.mod/keymap.c
 --- mutt-1.5.10/keymap.c=09Thu Feb  3 19:47:52 2005
 +++ mutt-1.5.10.mod/keymap.c=09Sun Aug 14 18:01:59 2005
 @@ -341,7 +341,7 @@ static void push_string (char *s)
  =09}
        }
      }
 -    mutt_ungetch (*p--, 0);
 +    mutt_ungetch ((unsigned char)*p--, 0);=09/* independent 8 bits c=
 hars */
    }
  }
 =20
 --- mutt/PATCHES=09Tue Nov  6 19:59:33 2001
 +++ mutt/PATCHES=09Tue Nov  6 19:59:42 2001
 @@ -1,0 +1 @@
 +patch-1.5.10.ab.bug2023_push_8bits.2
 
 
 --Boundary_(ID_jMXNb1tsw3zyAbt71BxhrQ)
 Content-type: TEXT/PLAIN; NAME=patchtagger
 Content-transfer-encoding: QUOTED-PRINTABLE
 Content-disposition: attachment; filename=patchtagger
 
 #!/bin/sh
 
 # Appends a PATCHES tag to Mutt patch files lacking it.
 # Usage: patchtagger [patchfile] ...
 
 for patchfile in $*
 do
   echo -ne "${patchfile}\t"
   if grep -q "^+++ .*PATCHES" "${patchfile}"
   then
     echo "Already tagged."
   else
     TAG=3D$(basename "${patchfile}" .diff)
     cat >> "${patchfile}" <<-END
 =09--- mutt/PATCHES=09Tue Nov  6 19:59:33 2001
 =09+++ mutt/PATCHES=09Tue Nov  6 19:59:42 2001
 =09@@ -1,0 +1 @@
 =09+${TAG}
 =09END
     echo "OK."
   fi
 done
 
 
 --Boundary_(ID_jMXNb1tsw3zyAbt71BxhrQ)--