<<< Date Index >>>     <<< Thread Index >>>

Re: strict aliasing due to wrong cast



* Brendan Cully <brendan@xxxxxxxxxx> [Aug 09. 2005 18:44]:
> > +++ copy.c      9 Aug 2005 11:58:28 -0000
> > @@ -418,7 +418,7 @@
> >  
> >         /* clearing refs from memory */
> >         for (t = refs; refs; refs = t->next, t = refs)
> > -         safe_free ((void **)&refs);
> > +         safe_free (&refs);
> >  
> >         if (fputc ('\n', out) == EOF)
> >           return (-1);
> 
> Applied, thanks (with safe_free replaced by FREE since mutt really
> enjoys using macros, for reasons I don't understand).

Historical reasons maybe?

Why is it BTW, that mutt is still insisting on being C89 (-ansi) when
it's in violation of it in several places.

I think we should either fix it, or remove the C89 compiler flag.

-- 
Mads Martin Joergensen, http://mmj.dk
"Why make things difficult, when it is possible to make them cryptic
 and totally illogical, with just a little bit more effort?"
                                -- A. P. J.