Re: Recommended patches

[Thomas Roessler <roessler@xxxxxxxxxxxxxxxxxx>]

On 2004-12-21 18:19:49 +0900, TAKAHASHI Tamotsu wrote:

> I'm afraid mutt-dev members didn't notice these important patches
> due to the delay of the list or any other reasons. See
> http://tamo.tdiary.net/20041221.html for clickable links.

Thanks for compiling this list.

> ==============================================
>  1. Security patches
> ==============================================
>      1. "decrypt-save" loses messages (bug1919, deb275188 - patch by tamo)

I think the real bug is in pgp.c:832:

diff -u -r3.31 pgp.c
--- pgp.c       8 Aug 2004 16:19:15 -0000       3.31
+++ pgp.c       21 Dec 2004 09:35:10 -0000
@@ -830,6 +830,10 @@
   *cur = pgp_decrypt_part (b, &s, *fpout, p);
 
   rewind (*fpout);
+  
+  if (!*cur) 
+    return -1;
+  
   return (0);
 }

I'm putting this change into the CVS.

>      2. "$write_bcc" is set by default

Despite using Exim myself, I still disagree that this should be
unset by default. ;-)

> ==============================================
>  2. Patches to fix bugs (in the code)
> ==============================================

Thanks again for collecting these.  I'll have a closer look at them
in the last week of the year.

Regards,
-- 
Thomas Roessler · Personal soap box at <http://log.does-not-exist.org/>.