[PATCH] signed bitfield in imap_private.h
Having a signed one-bit bitfield is quite odd -- its value is either
0 or -1. Although the current code is not broken because it doesn't
test equality to 1, IMHO it's better not to use that.
Regards,
Ralf
Index: imap/imap_private.h
===================================================================
RCS file: /home/roessler/cvs/mutt/imap/imap_private.h,v
retrieving revision 3.1
diff -u -r3.1 imap_private.h
--- imap/imap_private.h 15 Jul 2003 11:41:32 -0000 3.1
+++ imap/imap_private.h 7 Nov 2004 16:50:40 -0000
@@ -178,7 +178,7 @@
unsigned char rights[(RIGHTSMAX + 7)/8];
unsigned int newMailCount;
IMAP_CACHE cache[IMAP_CACHE_LEN];
- int noclose : 1;
+ unsigned int noclose : 1;
/* all folder flags - system flags AND keywords */
LIST *flags;