<<< Date Index >>>     <<< Thread Index >>>

Re: Bug#267015: inline-signed messages always sent in utf-8 ($send_charset not honoured)



[mutt-dev readers and Takashi TAKIZAWA can skip to the QUESTIONS
section.]

* Klaus Ethgen [Wed, 01 Sep 2004 20:21:53 +0200]:
> Hello,
  
  hi Klaus,

> I saw that the bug is closed.

> I do not think that it is closed! The last version without the bug was
> 1.5.6-20040523+1! Every version from 1.5.6-20040523+2 ut to the aktuell one 
> has
> this bug.

  we closed the bug because we didn't quite understand what was exactly
  your problem. let's say your explanation could have been a little more
  explicit, or our ability to understand you a little better.

> Well, this is NOT the problem. Inline signatures work fine with all versions I
> tested. The bug is that utf-8 is HARDCODED in mutt for the situation if you 
> use
> inline signature and have german umlauts in the mail.

  NOW I've understood, the key word is "HARDCODED". until you used it, I
  was unable to imagine what were you referring to.

  and yes, you're right: current mutt versions send inline-signed pgp
  mails ONLY in utf-8 and there is not a way to change that.

  NOTE, however, that *upstream* mutt has behaved like that for a couple
  years, and it was a debian applied patch (the compat patch) that
  changed that for a while and later reverted the change.

  given that, the discussion is whether that's a bug or not, and I guess
  there will be strong reasons to support this behavior.

  QUESTIONS:

    - can any mutt dev. provide a rationale for always sending messages
      with inline signatures in utf-8 instead of honouring
      $send_charset. I imagine that perhaps it is that verification does
      not work for some charsets (! iso-8859-1), but I'm not sure.

    - Takashi, can you explain what trouble did you find with the
      following excerpt from your compat patch (1.5.5.1), that you later
      removed it:

        --- mutt/pgp.c  2003-10-24 10:52:28.000000000 -0200
        +++ mutt.new/pgp.c      2003-12-21 00:14:34.000000000 -0200
        @@ -1302,12 +1302,8 @@
            int c;
            FGETCONV *fc;

        -    if (flags & ENCRYPT)
        -      send_charset = "us-ascii";
        -    else
        -      send_charset = "utf-8";
        -
        -    fc = fgetconv_open (fp, from_charset, "utf-8", M_ICONV_HOOK_FROM);
        +   send_charset = body_charset;
        +   fc = fgetconv_open (fp, from_charset, send_charset, 
M_ICONV_HOOK_FROM);
            while ((c = fgetconv (fc)) != EOF)
              fputc (c, pgpin);

> If I
> install a more aktuell version the characters gets converted to somewhat 
> strange
> (utf-8?) but as the content-type is allready iso-8859-1 the characters will 
> not
> readable anymore (in no mailreader!).

  sorry, but that's readable in *any* decent mailreader, and should be
  handled by lists archives (I think).

  thanks all for your attention. Klaus, I feel I can't do more wrt this
  issue. I've spotted the reason for the changed behavior and asked the
  appropriate parties to comment on it. I assume both Thomas and Takashi
  do things with good knowledge and for good reasons.

  cheers,

-- 
Adeodato Simó
    EM: asp16 [ykwim] alu.ua.es | PK: DA6AE621
 
A conference is a gathering of important people who singly can do nothing
but together can decide that nothing can be done.
                -- Fred Allen