bug#957: marked as done (mutt: Limited threaded display VASTLY slower in 1.3.25)
Your message dated Fri, 4 Jun 2004 19:34:01 +0100
with message-id <20040604183401.GA28517@xxxxxxxxxxxxxxxxxxxxx>
and subject line Close
has caused the attached bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Herr der Kaefer
(administrator, GUUG bugs database)
--------------------------------------
Received: (at submit) by bugs.guug.de; 7 Jan 2002 23:42:21 +0000
>From md@xxxxxxxx Tue Jan 08 00:42:21 2002
Received: from attila.bofh.it ([213.92.8.2] ident=postfix)
by trithemius.gnupg.org with esmtp (Exim 3.12 #1 (Debian))
id 16NjPJ-0001QX-00
for <submit@xxxxxxxxxxxx>; Tue, 08 Jan 2002 00:42:21 +0100
Received: by attila.bofh.it (Postfix, from userid 10)
id 8B58560F58; Tue, 8 Jan 2002 00:40:53 +0100 (CET)
Received: by wonderland.linux.it (Postfix/Md, from userid 1001)
id 5344A33B6F; Tue, 8 Jan 2002 00:40:28 +0100 (CET)
From: Marco d'Itri <md@xxxxxxxx>
To: submit@xxxxxxxxxxxx
Subject: mutt: Limited threaded display VASTLY slower in 1.3.25
X-GUUG-CC: 128174@xxxxxxxxxxxxxxx
Message-Id: <20020107234028.5344A33B6F@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 8 Jan 2002 00:40:28 +0100 (CET)
Package: mutt
Version: 1.3.25-2
[NOTE: this bug report has been submitted to the debian BTS as Bug#128174.
Please Cc all your replies to 128174@xxxxxxxxxxxxxxxx]
From: chip@xxxxxxxxxx
Subject: mutt: Limited threaded display VASTLY slower in 1.3.25
Date: Mon, 07 Jan 2002 13:25:28 -0800
Package: mutt
Version: 1.3.25-2
Severity: normal
Tags: patch
The threading tweaks in 1.3.25 caused a HUGE slowdown in limited
(partially hidden) threaded displays. (Re-enabling optimization
was a good thing, but it did *not* fix this problem.)
The below patch makes the slowdown somewhat less painful, but more
work is required to really fix things.
Index: mutt-1.3.25/thread.c
--- mutt-1.3.25/thread.c.prev
+++ mutt-1.3.25/thread.c Thu Jan 3 14:51:54 2002
@@ -203,5 +203,5 @@ void mutt_linearize_tree (CONTEXT *ctx,
}
- nextdisp = 0;
+ nextdisp = -1;
do
@@ -221,5 +221,5 @@ void mutt_linearize_tree (CONTEXT *ctx,
if (tree->fake_thread)
pseudo = 1;
- if (!nextdisp)
+ if (nextdisp < 0)
nextdisp = is_next_displayed (ctx, tree);
hdr = tree->message;
@@ -234,4 +234,6 @@ void mutt_linearize_tree (CONTEXT *ctx,
tree = tree->parent;
hdr = tree->message;
+ if (nextdisp == 0)
+ nextdisp = -1;
if (hdr || !option (OPTHIDEMISSING) || tree->child->next)
@@ -248,5 +250,5 @@ void mutt_linearize_tree (CONTEXT *ctx,
if (!tree)
break;
- if (!nextdisp)
+ if (nextdisp < 0)
nextdisp = is_next_displayed (ctx, tree);
if (tree->fake_thread)
@@ -256,4 +258,7 @@ void mutt_linearize_tree (CONTEXT *ctx,
}
while (!(hdr || !option (OPTHIDEMISSING) || tree->child->next));
+
+ if (nextdisp < 0)
+ nextdisp = 0;
}
-- System Information
Debian Release: 3.0
Kernel Version: Linux tytlal 2.4.17 #1 Fri Dec 21 19:01:57 PST 2001 i686 unknown
Versions of the packages mutt depends on:
ii libc6 2.2.4-7 GNU C Library: Shared libraries and Timezone
ii libncurses5 5.2.20010318-3 Shared libraries for terminal handling
ii libsasl7 1.5.27-2 Authentication abstraction library.
ii exim-tls 3.33-2.0chip2 Exim Mailer - with TLS (SSL) support
^^^ (Provides virtual package exim)
ii exim-tls 3.33-2.0chip2 Exim Mailer - with TLS (SSL) support
^^^ (Provides virtual package mail-transport-agent)
---------------------------------------
Received: (at 957-done) by bugs.guug.de; 6 Jun 2004 21:01:11 +0000
>From paul@xxxxxxxxxxxxxxxxxxxxx Sun Jun 06 23:01:01 2004
Received: from anchor-fallback-93.mail.demon.net ([194.217.242.93])
by trithemius.gnupg.org with esmtp (Exim 3.35 #1 (Debian))
id 1BX4lJ-0002kF-00
for <957-done@xxxxxxxxxxxx>; Sun, 06 Jun 2004 23:01:01 +0200
Received: from anchor-post-34.mail.demon.net ([194.217.242.92]:2646 "EHLO
anchor-post-34.mail.demon.net") by anchor-fallback-93.mail.demon.net
with ESMTP id S1155977AbUFDWo4 (ORCPT
<rfc822;957-done@xxxxxxxxxxxx>); Fri, 4 Jun 2004 23:44:56 +0100
Received: from black-sun.demon.co.uk ([212.228.147.62] helo=nova)
by anchor-post-34.mail.demon.net with esmtp (Exim 3.35 #1)
id 1BWJW3-000IRA-0Y
for 957-done@xxxxxxxxxxxx; Fri, 04 Jun 2004 19:34:07 +0100
Received: from paul
by nova with local id 1BWJVx-0007QC-NX
for <957-done@xxxxxxxxxxxx>; Fri, 04 Jun 2004 19:34:01 +0100
Date: Fri, 4 Jun 2004 19:34:01 +0100
From: Paul Walker <paul@xxxxxxxxxxxxxxxxxxxxx>
To: 957-done@xxxxxxxxxxxx
Subject: Close
Message-ID: <20040604183401.GA28517@xxxxxxxxxxxxxxxxxxxxx>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="8t9RHnE3ZwKMSgU+"
Content-Disposition: inline
User-Agent: Mutt/1.5.5.1+cvs20040105i
X-Spam-Status: No, hits=-106.9 required=4.0
tests=AWL,BAYES_20,PGP_SIGNATURE_2,USER_AGENT_MUTT,
USER_IN_WHITELIST
autolearn=ham version=2.55
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)
--8t9RHnE3ZwKMSgU+
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Debian BTS reports bug closed.
--=20
Paul
212. I will not send out battalions composed wholly of robots or
skeletons against heroes who have qualms about killing living
beings.
--8t9RHnE3ZwKMSgU+
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFAwMCZP9fOqdxRstoRAsuNAJ9g3gDOf0faLrTriKTzDFU4SkHP9QCfStmY
Jv7GluwbHCmRyqjDNG7ySis=
=W4uF
-----END PGP SIGNATURE-----
--8t9RHnE3ZwKMSgU+--