[PATCHES] awaiting...
I recently posted multiple patches.
Please commit these changes to cvs if you don't find a bug in them.
These really fix problems, and I have not experienced any side effect.
I have been testing them for at least three days.
BTW, Don't forget assumed_charset patch and hcache patch!
http://www.emaillab.org/mutt/1.5/patch-1.5.6.tt.assumed_charset.1.gz
(I have been using JA patch for YEARS! This is a great patch.)
http://wwwcip.informatik.uni-erlangen.de/~sithglan/mutt/
(hcache patch version 13 is available. I have been using hcache.8 and
have not experienced any problems. AFAIK hcache.8 has no bug.)
--- /dev/null Sat May 22 21:00:00 2004
+++ PATCHES Sat May 22 21:00:00 2004
@@ -1,0 +1 @@
+patch-1.5.6.tamo.builtin+browser+keymap.1
Date: Fri, 7 May 2004 16:23:57 +0900
Subject: Re: Using the builtin editor
--- compose.c~ Tue Apr 13 09:01:33 2004
+++ compose.c Fri May 7 16:10:37 2004
@@ -733,7 +733,7 @@
/* fall through */
case OP_COMPOSE_EDIT_HEADERS:
if (op == OP_COMPOSE_EDIT_HEADERS ||
- (op == OP_COMPOSE_EDIT_MESSAGE && option (OPTEDITHDRS)))
+ (op == OP_COMPOSE_EDIT_MESSAGE && option (OPTEDITHDRS) &&
(mutt_strcmp ("builtin", Editor) != 0)))
{
char *tag = NULL, *err = NULL;
mutt_env_to_local (msg->env);
Date: Sat, 15 May 2004 14:34:40 +0900
Subject: Re: [BETTER PATCH] Re: Bug#237426: Mutt segfaults on unreadable
directories
--- browser.c.old Wed Nov 5 18:41:31 2003
+++ browser.c Sat May 15 14:29:52 2004
@@ -944,21 +944,21 @@
{
if (S_ISDIR (st.st_mode))
{
- strfcpy (LastDir, buf, sizeof (LastDir));
destroy_state (&state);
- if (examine_directory (menu, &state, LastDir, prefix) == 0)
- {
- menu->current = 0;
- menu->top = 0;
- init_menu (&state, menu, title, sizeof (title), buffy);
- }
+ if (examine_directory (menu, &state, buf, prefix) == 0)
+ strfcpy (LastDir, buf, sizeof (LastDir));
else
{
mutt_error _("Error scanning directory.");
- destroy_state (&state);
- mutt_menuDestroy (&menu);
- goto bail;
+ if (examine_directory (menu, &state, LastDir, prefix) == -1)
+ {
+ mutt_menuDestroy (&menu);
+ goto bail;
+ }
}
+ menu->current = 0;
+ menu->top = 0;
+ init_menu (&state, menu, title, sizeof (title), buffy);
}
else
mutt_error (_("%s is not a directory."), buf);
Date: Thu, 20 May 2004 12:33:44 +0900
Subject: bug#1880: mutt-1.5.6i: deference between noop and unbound
--- keymap.c~ Wed May 19 23:46:11 2004
+++ keymap.c Thu May 20 12:15:32 2004
@@ -443,6 +443,9 @@
if (LastKey != map->keys[pos])
return (retry_generic (menu, map->keys, pos, LastKey));
+ if (map->op == OP_NULL)
+ return (retry_generic (menu, map->keys, pos, LastKey));
+
if (++pos == map->len)
{
--
tamo