<<< Date Index >>>     <<< Thread Index >>>

Re: bug#1884: mutt-1.5.6i: Bug in source_rc()?



David Yitzchak Cohen wrote:

>> mutt complains that "~/.mutt/scripts/chkmbox|" does not exist.

> The bug was fixed in CVS only a few days after 1.5.6i was
> released.

Oh, I see. I was already wondering why I couldn't find any bug 
reports addressing this issue. This is a real showstopper,
IMHO. SUSE 9.1 ships this broken version, btw. :-(

> In other words, no stat(2)ing should be done at all if it's a
> command.  The patch in CVS does just that.

It seems, this one just reverts another patch that has introduced
the bug earlier, right?

>> For what it's worth, here is a patch that seemed to fix the
>> problem for me.

> Well, it fixes your particular case, but leaves many other cases
> broken.

Most notably command line options. True.

> These checks are better done in mutt_open_read(), which you're
> about to call anyway:

Yup. The CVS version seems to do this in mutt_open_read().
However, 1.5.6i does it in source_rc(). So I tried to fix it in
place, which was obviously a waste of time. :-/

> Thanks for taking the initiative to fix bugs, rather than simply
> reverting back to 1.5.5.1i :-)

Well, I deny myself telling you which version I came from. ;-)

Regards - Juergen

-- 
GPG A997BA7A | 87FC DA31 5F00 C885 0DC3  E28F BD0D 4B33 A997 BA7A

Attachment: pgpYQj9yTOU1G.pgp
Description: PGP signature