bug#844: marked as done (mutt-1.3.23i: decode copy doesn't decode headers)
Your message dated Mon, 29 Dec 2003 12:47:58 +0100
with message-id <20031229114758.GN2270@xxxxxxxxxxxxxxxxxxxxxxxxxx>
and subject line bug#844: mutt-1.3.23i: decode copy doesn't decode headers
has caused the attached bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Herr der Kaefer
(administrator, GUUG bugs database)
--------------------------------------
Received: (at submit) by bugs.guug.de; 29 Oct 2001 18:50:56 +0000
>From utx@xxxxxxxxxx Mon Oct 29 19:50:56 2001
Received: from smtp3.vol.cz ([195.250.128.83])
by trithemius.gnupg.org with esmtp (Exim 3.12 #1 (Debian))
id 15yHUu-00081W-00
for <submit@xxxxxxxxxxxx>; Mon, 29 Oct 2001 19:50:56 +0100
Received: from utx.cz (datelb-1-3-90.dialup.vol.cz [212.20.100.236])
by smtp3.vol.cz (8.11.3/8.11.3) with ESMTP id f9TImpj55164
for <submit@xxxxxxxxxxxx>; Mon, 29 Oct 2001 19:49:01 +0100 (CET)
(envelope-from utx@xxxxxxxxxx)
Received: (from sb@localhost)
by utx.cz (8.10.2/8.10.2) id f9T9wRh00968;
Mon, 29 Oct 2001 10:58:27 +0100
Date: Mon, 29 Oct 2001 10:58:27 +0100
From: Stanislav Brabec <utx@xxxxxxxxxx>
Message-Id: <200110290958.f9T9wRh00968@xxxxxx>
Subject: mutt-1.3.23i: decode copy doesn't decode headers
To: submit@xxxxxxxxxxxx
Package: mutt
Version: 1.3.23i
Severity: normal
-- Please type your report below this line
When I request Decode-Copy, whole mail body is correctly decoded to
text/plain. But in my opinion, decoded copy should have also decoded
headers. In my case it was:
From: "=?iso-8859-2?Q?Jarmila_Michnov=E1?=" <michnova@xxxxxx>
or
Subject: =?iso-8859-2?B?b2RobOG5ZW7tIERvdGVrdQ==?=
Thanks
-- Mutt Version Information
Mutt 1.3.23i (2001-10-09)
Copyright (C) 1996-2001 Michael R. Elkins a dal¹í.
Mutt je roz¹iøován BEZ JAKÉKOLI ZÁRUKY; dal¹í informace získáte pøíkazem
`mutt -vv'.
Mutt je volné programové vybavení. Roz¹iøování tohoto programu je vítáno,
musíte ov¹em dodr¾et urèitá pravidla; dal¹í informace získáte pøíkazem
`mutt -vv'.
System: Linux 2.4.13 [using ncurses 5.2]
Pøelo¾eno s volbami:
-DOMAIN
+DEBUG
-HOMESPOOL +USE_SETGID +USE_DOTLOCK +DL_STANDALONE
+USE_FCNTL -USE_FLOCK
-USE_POP +USE_IMAP -USE_GSS -USE_SSL -USE_SASL
+HAVE_REGCOMP -USE_GNU_REGEX
+HAVE_COLOR +HAVE_START_COLOR +HAVE_TYPEAHEAD +HAVE_BKGDSET
+HAVE_CURS_SET +HAVE_META +HAVE_RESIZETERM
+HAVE_PGP -BUFFY_SIZE -EXACT_ADDRESS -SUN_ATTACHMENT
+ENABLE_NLS -LOCALES_HACK +HAVE_WC_FUNCS +HAVE_LANGINFO_CODESET
+HAVE_LANGINFO_YESEXPR
+HAVE_ICONV -ICONV_NONTRANS +HAVE_GETSID +HAVE_GETADDRINFO
ISPELL="/usr/bin/ispell"
SENDMAIL="/usr/sbin/sendmail"
MAILPATH="/var/mail"
PKGDATADIR="/usr/share/mutt"
SYSCONFDIR="/etc"
EXECSHELL="/bin/sh"
-MIXMASTER
Vývojáøe programu mù¾ete kontaktovat na adrese <mutt-dev@xxxxxxxx> (anglicky).
Chyby v programu oznamujte pomocí utility flea(1).
Pøipomínky k pøekladu zasílejte na adresu <cs@xxxxxx> (èesky).
---------------------------------------
Received: (at 844-done) by bugs.guug.de; 29 Dec 2003 11:45:48 +0000
>From roessler+bounce@xxxxxxxxxxxxxxxxxx Mon Dec 29 12:45:45 2003
Received: from does-not-exist.info ([217.160.221.198]
helo=kamino.does-not-exist.org)
by trithemius.gnupg.org with esmtp (Exim 3.35 #1 (Debian))
id 1AavqD-0007bp-00
for <844-done@xxxxxxxxxxxx>; Mon, 29 Dec 2003 12:45:45 +0100
Received: from voyager.does-not-exist.org (unknown [195.46.244.11])
(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))
(No client certificate requested)
by kamino.does-not-exist.org (Postfix) with ESMTP
id 1C6373140D5; Mon, 29 Dec 2003 12:48:20 +0100 (CET)
Received: by voyager.does-not-exist.org (Postfix, from userid 500)
id 2816880A5; Mon, 29 Dec 2003 12:47:59 +0100 (CET)
Date: Mon, 29 Dec 2003 12:47:58 +0100
From: Thomas Roessler <roessler@xxxxxxxxxxxxxxxxxx>
To: 844-done@xxxxxxxxxxxx, Stanislav Brabec <utx@xxxxxxxxxx>
Subject: Re: bug#844: mutt-1.3.23i: decode copy doesn't decode headers
Message-ID: <20031229114758.GN2270@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <200110290958.f9T9wRh00968@xxxxxx> <20031225190129.GA31820@xxxxxxx>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20031225190129.GA31820@xxxxxxx>
User-Agent: Mutt/1.5.5.1i
X-Spam-Status: No, hits=-109.8 required=4.0
tests=AWL,BAYES_01,EMAIL_ATTRIBUTION,IN_REP_TO,QUOTED_EMAIL_TEXT,
REFERENCES,REPLY_WITH_QUOTES,USER_AGENT_MUTT,
USER_IN_WHITELIST
autolearn=ham version=2.55
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)
thanks. committed.
--
Thomas Roessler <roessler@xxxxxxxxxxxxxxxxxx>
On 2003-12-25 20:01:30 +0100, Alain Bench wrote:
> From: Alain Bench <veronatif@xxxxxxx>
> To: 844@xxxxxxxxxxxx
> Cc: Stanislav Brabec <utx@xxxxxxxxxx>
> Date: Thu, 25 Dec 2003 20:01:30 +0100 (CET)
> Subject: bug#844: mutt-1.3.23i: decode copy doesn't decode headers
> Reply-To: Alain Bench <veronatif@xxxxxxx>, 844@xxxxxxxxxxxx
> Mail-Followup-To: 844@xxxxxxxxxxxx, Stanislav Brabec <utx@xxxxxxxxxx>
> X-Spam-Level:
>
> Hello Stanislav, and much thanks for the bug report.
>
> On Monday, October 29, 2001 at 10:58:27 AM +0100, Stanislav Brabec wrote:
>
> > When I request Decode-Copy, whole mail body is correctly decoded to
> > text/plain. But in my opinion, decoded copy should have also decoded
> > headers. In my case it was:
> >| From: "=?iso-8859-2?Q?Jarmila_Michnov=E1?=" <michnova@xxxxxx>
> > or
> >| Subject: =?iso-8859-2?B?b2RobOG5ZW7tIERvdGVrdQ==?=
>
> Agreed. Headers should be decoded and converted to your $charset.
> Unconvertable chars replaced by question marks, just as for display. In
> msgid <20031005133021.GA22392@xxxxxxx> for now closed bug #1072 I said:
>
> | <decode-save> main purpose is to render a text file usable with any
> | even non-mail tools outside Mutt (perhaps to edit it, print, process
> | in any way...). So it's natural MIME encodings are decoded, charset
> | converted to $charset, HTML rendered, unused multipart/alts removed,
> | bin attachments removed, headers weeded on demand in a configurable
> | way, etc... Resulting text file is subject to every "rendering"
> | setting in Mutt or helper apps: auto_view, alternative_order, ignore,
> | hdr_order, $weed, $charset, charset-hook, $display_filter, and so on.
> |
> | Note: In this scheme it would be natural <decode-save> decodes RFC
> | 2047 encoded headers (and iconvs them to $charset). But it does not,
> | see bug #844.
>
> The attached patch-1.4.ab.decode_save_headers.1 should fix this
> behaviour. It applies cleanly to 1.4 and 1.5.5.1 (but I tested the
> feature only on 1.4).
>
>
> Bye! Alain.
> --
> Mutt muttrc tip for mailing lists: set followup_to=yes and declare the list as
> - subscribe list@ddress if you are subscribed and don't want courtesy copy.
> - lists list@ddress if you are not subscribed or want a courtesy copy.
> Functions <decode-save> and <decode-copy> decode RFC 2047 headers
> and convert them to $charset. Fixes bug #844. See msgid
> <20031005133021.GA22392@xxxxxxx> in bug #1072 for discussion. AB.
>
> diff -prud mutt-1.4.orig/commands.c mutt-1.4/commands.c
> --- mutt-1.4.orig/commands.c Wed Apr 3 12:54:19 2002
> +++ mutt-1.4/commands.c Thu Dec 25 16:42:39 2003
> @@ -598,16 +598,17 @@ static void set_copy_flags (HEADER *hdr,
> {
> *chflags = CH_XMIT | CH_MIME | CH_TXTPLAIN;
> *cmflags = M_CM_DECODE | M_CM_CHARCONV;
> - }
>
> - /* respect $weed only if decode doesn't kick in
> - * for decrypt.
> - */
> + if (!decrypt) /* If decode doesn't kick in for decrypt, */
> + {
> + *chflags |= CH_DECODE; /* then decode RFC 2047 headers, */
>
> - if (decode && !decrypt && option (OPTWEED))
> - {
> - *chflags |= CH_WEED;
> - *cmflags |= M_CM_WEED;
> + if (option (OPTWEED))
> + {
> + *chflags |= CH_WEED; /* and respect $weed. */
> + *cmflags |= M_CM_WEED;
> + }
> + }
> }
> }
>
> --- PATCHES Tue Nov 6 19:59:33 2001
> +++ PATCHES Tue Nov 6 19:59:42 2001
> @@ -1,0 +1 @@
> +patch-1.4.ab.decode_save_headers.1