<<< Date Index >>>     <<< Thread Index >>>

bug#1656: marked as done (mutt: Tagging ignored in Attachments list)



Your message dated Sat, 4 Oct 2003 18:42:50 +0200
with message-id <20031004164250.GC1114@xxxxxxxxxxxxxxxxxxxxxxxxxx>
and subject line bug#1656: mutt: Tagging ignored in Attachments list
has caused the attached bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Herr der Kaefer
(administrator, GUUG bugs database)

--------------------------------------
Received: (at submit) by bugs.guug.de; 3 Oct 2003 13:08:04 +0000
>From md@xxxxxxxx Fri Oct 03 15:07:46 2003
Received: from attila.bofh.it ([213.92.8.2] ident=postfix)
        by trithemius.gnupg.org with esmtp (Exim 3.35 #1 (Debian))
        id 1A5Pes-0004Hs-00
        for <submit@xxxxxxxxxxxx>; Fri, 03 Oct 2003 15:07:46 +0200
Received: by attila.bofh.it (Postfix, from userid 10)
        id 5D8A35F811; Fri,  3 Oct 2003 15:10:11 +0200 (CEST)
Received: by wonderland.linux.it (Postfix, from userid 1001)
        id 42DFF1D4DA; Fri,  3 Oct 2003 15:09:47 +0200 (CEST)
From: Marco d'Itri <md@xxxxxxxx>
To: submit@xxxxxxxxxxxx
Subject: mutt: Tagging ignored in Attachments list
X-GUUG-CC: 213917@xxxxxxxxxxxxxxx
Message-Id: <20031003130947.42DFF1D4DA@xxxxxxxxxxxxxxxxxxx>
Date: Fri,  3 Oct 2003 15:09:47 +0200 (CEST)
X-Spam-Status: No, hits=-104.0 required=5.0
        tests=AWL,BAYES_10,USER_IN_WHITELIST
        version=2.55
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)

Package: mutt
Version: 1.5.4+20030913-1
Severity: normal

[NOTE: this bug report has been submitted to the debian BTS as Bug#213917.
Please Cc all your replies to 213917@xxxxxxxxxxxxxxx .]

From: John Harrison <john@xxxxxxx>
Subject: mutt: Tagging ignored in Attachments list
Date: Fri, 03 Oct 2003 14:00:03 +0100

When attachments are tagged in the "View Atachments" screen using "t"
and then the tag-prefix ; is used to process the tagged attachments,
(e.g. to "s" save all the tagged attachments
      or to "d" to mark the tagged attachments as deleted)
only the attachment under the cursor is acted on
(as if the ";" had not been pressed first)

If ";" is pressed when no attachments have been tagged it correctly
gives the error "No tagged entries."

So it knows when there are tagged entries, it just ignores the fact that
it should be acting on them and not on the entry under the cursor when
the command follows ";"

This problem is only occuring in the latest release (1.5.4+20030913-1)
it does not happen in mutt_1.5.4-1

-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux aotea 2.4.22-1-686-smp #4 SMP Sun Sep 28 13:30:30 EST 2003 i686
Locale: LANG=C, LC_CTYPE=en_GB

Versions of packages mutt depends on:
ii  exim [mail-transport-agen 3.36-8         An MTA (Mail Transport Agent)
ii  libc6                     2.3.2-8        GNU C Library: Shared libraries an
ii  libidn9                   0.1.14-2       GNU libidn library, implementation
ii  libncurses5               5.3.20030719-2 Shared libraries for terminal hand
ii  libsasl2                  2.1.15-5.2     Authentication abstraction library

-- no debconf information


---------------------------------------
Received: (at 1656-done) by bugs.guug.de; 4 Oct 2003 16:38:49 +0000
>From roessler+bounce@xxxxxxxxxxxxxxxxxx Sat Oct 04 18:38:47 2003
Received: from does-not-exist.info ([217.160.221.198] 
helo=kamino.does-not-exist.org)
        by trithemius.gnupg.org with esmtp (Exim 3.35 #1 (Debian))
        id 1A5pQc-00020U-00
        for <1656-done@xxxxxxxxxxxx>; Sat, 04 Oct 2003 18:38:46 +0200
Received: from voyager.does-not-exist.org (unknown [195.46.244.24])
        (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))
        (No client certificate requested)
        by kamino.does-not-exist.org (Postfix) with ESMTP
        id 1130B3140D5; Sat,  4 Oct 2003 18:41:11 +0200 (CEST)
Received: by voyager.does-not-exist.org (Postfix, from userid 500)
        id 5E28080F0; Sat,  4 Oct 2003 18:42:51 +0200 (CEST)
Date: Sat, 4 Oct 2003 18:42:50 +0200
From: Thomas Roessler <roessler@xxxxxxxxxxxxxxxxxx>
To: Marco d'Itri <md@xxxxxxxx>, 1656-done@xxxxxxxxxxxx,
        213917@xxxxxxxxxxxxxxx
Subject: Re: bug#1656: mutt: Tagging ignored in Attachments list
Message-ID: <20031004164250.GC1114@xxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <20031003130947.42DFF1D4DA@xxxxxxxxxxxxxxxxxxx>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="A6N2fC+uXW/VQSAv"
Content-Disposition: inline
In-Reply-To: <20031003130947.42DFF1D4DA@xxxxxxxxxxxxxxxxxxx>
User-Agent: Mutt/1.5.4i
X-Spam-Status: No, hits=-110.6 required=5.0
        tests=BAYES_00,IN_REP_TO,PGP_SIGNATURE_2,REFERENCES,
              USER_AGENT_MUTT,USER_IN_WHITELIST
        autolearn=ham version=2.55
X-Spam-Level: 
X-Spam-Checker-Version: SpamAssassin 2.55 (1.174.2.19-2003-05-19-exp)


--A6N2fC+uXW/VQSAv
Content-Type: multipart/mixed; boundary="r5Pyd7+fXNt84Ff3"
Content-Disposition: inline


--r5Pyd7+fXNt84Ff3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

The attached patch should fix this problem.
--=20
Thomas Roessler                       <roessler@xxxxxxxxxxxxxxxxxx>

--r5Pyd7+fXNt84Ff3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="patch-1.5.4.tlr.tag_prefix.1"
Content-Transfer-Encoding: quoted-printable

? err
? patch-1.5.3-CVS.tlr.idna.1
? patch-1.5.4.nr.tag_prefix_cond
? patch-1.5.4.tlr.nodots.1
? patch-1.5.4.tlr.pgpsmimeautoselect.1
? patch-1.5.4.tlr.tag_prefix.1
? send.c.new
? sort.c.new
? stamp-h1
? typescript
Index: menu.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/mutt/mutt/menu.c,v
retrieving revision 3.8
diff -u -r3.8 menu.c
--- menu.c      4 Jul 2003 17:07:22 -0000       3.8
+++ menu.c      4 Oct 2003 16:38:04 -0000
@@ -856,7 +856,7 @@
       return i;
                   =20
     i =3D km_dokey (menu->menu);
-    if (i =3D=3D OP_TAG_PREFIX)
+    if (i =3D=3D OP_TAG_PREFIX || i =3D=3D OP_TAG_PREFIX_COND)
     {
       if (menu->tagged)
       {
@@ -866,23 +866,12 @@
        menu->tagprefix =3D 1;
        CLEARLINE (LINES - 1);
       }
-      else=20
+      else if (i =3D=3D OP_TAG_PREFIX)
       {
        mutt_error _("No tagged entries.");
        i =3D -1;
       }
-    }
-    if (i =3D=3D OP_TAG_PREFIX_COND)
-    {
-      if (menu->tagged)
-      {
-       mvaddstr (LINES - 1, 0, "Tag-");
-       clrtoeol ();
-       i =3D km_dokey (menu->menu);
-       menu->tagprefix =3D 1;
-       CLEARLINE (LINES - 1);
-      }
-      else=20
+      else /* None tagged, OP_TAG_PREFIX_COND */
       {
        event_t tmp;
        while(UngetCount>0)

--r5Pyd7+fXNt84Ff3--

--A6N2fC+uXW/VQSAv
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)

iD8DBQE/fviJA+zWmZc3wN0RAjqjAJ4/+zWyKTOQqpxAKlgU9X2rzbAXpgCgn5qf
DUVlVYL7XHIouMJ2GMWOT/E=
=oo8Y
-----END PGP SIGNATURE-----

--A6N2fC+uXW/VQSAv--