bug#1036: marked as done (mutt: segfault when more than one msg is postponed in the posponed folder)
Your message dated Wed, 3 Sep 2003 19:25:49 +0200
with message-id <20030903172549.GG22011@xxxxxxxxxxxxxxxxxxxxxxxxxx>
and subject line Patch for bug 1036
has caused the attached bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Herr der Kaefer
(administrator, GUUG bugs database)
--------------------------------------
Received: (at submit) by bugs.guug.de; 9 Feb 2002 01:28:02 +0000
>From md@xxxxxxxx Sat Feb 09 02:28:02 2002
Received: from attila.bofh.it ([213.92.8.2] ident=postfix)
by trithemius.gnupg.org with esmtp (Exim 3.12 #1 (Debian))
id 16ZMJ8-0003pS-00
for <submit@xxxxxxxxxxxx>; Sat, 09 Feb 2002 02:28:02 +0100
Received: by attila.bofh.it (Postfix, from userid 10)
id 7EEC161578; Sat, 9 Feb 2002 02:26:33 +0100 (CET)
Received: by wonderland.linux.it (Postfix/Md, from userid 1001)
id 6709E340C0; Sat, 9 Feb 2002 02:10:43 +0100 (CET)
From: Marco d'Itri <md@xxxxxxxx>
To: submit@xxxxxxxxxxxx
Subject: mutt: segfault when more than one msg is postponed in the posponed
folder
X-GUUG-CC: 133021@xxxxxxxxxxxxxxx
Message-Id: <20020209011043.6709E340C0@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 9 Feb 2002 02:10:43 +0100 (CET)
Package: mutt
Version: 1.3.27-2
[NOTE: this bug report has been submitted to the debian BTS as Bug#133021.
Please Cc all your replies to 133021@xxxxxxxxxxxxxxxx]
From: Mike Fedyk <mfedyk@xxxxxxxxxxxxx>
Subject: mutt: segfault when more than one msg is postponed in the posponed
folder
Date: Fri, 08 Feb 2002 13:52:49 -0800
Package: mutt
Version: 1.3.27-2
Severity: normal
With two or more postponed messages in the posponed folder mutt segfaults:
Reading /home/mfedyk/Mail/postponed... 1 (8%)Segmentation fault
It is the same wheather postponed is in ~ or ~/Mail...
-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux mis-mike-wstn 2.4.18-pre7-aa2 #1 SMP Tue Feb 5 19:25:32 PST 2002
i686
Locale: LANG=english, LC_CTYPE=english
Versions of packages mutt depends on:
ii exim 3.33-1.1 Exim Mailer
ii exim [mail-transport-age 3.33-1.1 Exim Mailer
ii libc6 2.2.4-7 GNU C Library: Shared libraries an
ii libncurses5 5.2.20020112a-3 Shared libraries for terminal hand
ii libsasl7 1.5.27-2 Authentication abstraction library
---------------------------------------
Received: (at 1036-done) by bugs.guug.de; 3 Sep 2003 17:22:20 +0000
>From roessler@xxxxxxxxxxxxxxxxxxxxxxxxxx Wed Sep 03 19:22:20 2003
Received: from does-not-exist.info ([217.160.221.198]
helo=kamino.does-not-exist.org)
by trithemius.gnupg.org with esmtp (Exim 3.35 #1 (Debian))
id 19ubKm-0003JO-00
for <1036-done@xxxxxxxxxxxx>; Wed, 03 Sep 2003 19:22:20 +0200
Received: from voyager.does-not-exist.org (schroedinger.iam.uni-bonn.de
[131.220.223.204])
(using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits))
(No client certificate requested)
by kamino.does-not-exist.org (Postfix) with ESMTP
id C83D93140D6; Wed, 3 Sep 2003 19:24:40 +0200 (CEST)
Received: by voyager.does-not-exist.org (Postfix, from userid 500)
id 160F98122; Wed, 3 Sep 2003 19:25:50 +0200 (CEST)
Date: Wed, 3 Sep 2003 19:25:49 +0200
From: Thomas Roessler <roessler@xxxxxxxxxxxxxxxxxx>
To: mutt-dev@xxxxxxxx, 1036-done@xxxxxxxxxxxx
Subject: Re: Patch for bug 1036
Message-ID: <20030903172549.GG22011@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Mail-Followup-To: mutt-dev@xxxxxxxx, 1036-done@xxxxxxxxxxxx
References: <20030821062926.GA12505@xxxxxxxxxxx>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20030821062926.GA12505@xxxxxxxxxxx>
User-Agent: Mutt/1.5.4i
Committed.
On 2003-08-21 02:29:26 -0400, Dan Born wrote:
> From: Dan Born <dan@xxxxxxxxxxx>
> To: mutt-dev@xxxxxxxx
> Date: Thu, 21 Aug 2003 02:29:26 -0400
> Subject: Patch for bug 1036
> Mail-Followup-To: mutt-dev@xxxxxxxx
> X-Spam-Level:=20
>=20
> I've attached a patch for bug number 1036, as reported at
> http://bugs.guug.de/db/pa/lmutt.html ("segfault when more than one msg is
> postponed"). This is a patch against mutt 1.4.1.
>=20
> As it was previously left, no one could reproduce it. The problem
> occurs because sorting is disabled when opening the postponed folder,
> but the Sort global variable still tells mutt to use whatever sorting
> algorithm the $sort config option indicates. Eventually, the code would
> get to mutt_messages_in_thread and try to dereference a NULL thread
> object, causing the segfault.
>=20
> --=20
> Dan Born
> Common subdirectories: mutt-1.4.1/contrib and mutt-danborn/contrib
> Common subdirectories: mutt-1.4.1/doc and mutt-danborn/doc
> Common subdirectories: mutt-1.4.1/imap and mutt-danborn/imap
> Common subdirectories: mutt-1.4.1/intl and mutt-danborn/intl
> Common subdirectories: mutt-1.4.1/m4 and mutt-danborn/m4
> Common subdirectories: mutt-1.4.1/po and mutt-danborn/po
> diff -u mutt-1.4.1/postpone.c mutt-danborn/postpone.c
> --- mutt-1.4.1/postpone.c Wed Oct 31 04:20:38 2001
> +++ mutt-danborn/postpone.c Thu Aug 21 01:59:40 2003
> @@ -23,6 +23,7 @@
> #include "mime.h"
> #include "mailbox.h"
> #include "mapping.h"
> +#include "sort.h"
> #ifdef USE_IMAP
> #include "mx.h"
> #include "imap.h"
> @@ -157,6 +158,7 @@
> MUTTMENU *menu;
> int i, done=3D0, r=3D-1;
> char helpstr[SHORT_STRING];
> + short orig_sort;
> =20
> menu =3D mutt_new_menu ();
> menu->make_entry =3D post_entry;
> @@ -166,6 +168,12 @@
> menu->data =3D PostContext;
> menu->help =3D mutt_compile_help (helpstr, sizeof (helpstr), MENU_POST=
, PostponeHelp);
> =20
> + /* The postponed mailbox is setup to have sorting disabled, but the gl=
obal
> + * Sort variable may indicate something different. Sorting has to be
> + * disabled while the postpone menu is being displayed. */
> + orig_sort =3D Sort;
> + Sort =3D SORT_ORDER;
> + =20
> while (!done)
> {
> switch (i =3D mutt_menuLoop (menu))
> @@ -201,6 +209,7 @@
> }
> }
> =20
> + Sort =3D orig_sort;
> mutt_menuDestroy (&menu);
> return (r > -1 ? PostContext->hdrs[r] : NULL);
> }
--=20
Thomas Roessler =B7 Personal soap box at <http://log.does-not-exist.org/>.